[HOLD for payment 2024-02-01] [$250] [TS migration] Migrate 'KYCWall' component to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/KYCWall/kycWallPropTypes.js	6
src/components/KYCWall/index.native.js	1
src/components/KYCWall/index.js	3
src/components/KYCWall/BaseKYCWall.js	15

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a04224e913b4fab2
• Upwork Job ID: 1747587927070720000
• Last Price Increase: 2024-01-19

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[ruben-rebelo]

I am Ruben Rebelo from Callstack - expert contributor group. I’d like to work on this job.

[melvin-bot]

📣 @ruben-rebelo! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rushatgabhane]

@Julesssss the PR is approved

[melvin-bot]

Triggered auto assignment to @alexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[Julesssss]

Merged, awaiting deployment

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a04224e913b4fab2

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Upwork job price has been updated to $250

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[alexpensify]

@rushatgabhane - can we get your feedback if regression was caused by this PR? Thanks!

[rushatgabhane]

@alexpensify yes, it was caused by this PR

[alexpensify]

Ok, is there a plan to fix or revert this PR? I don't see one associated with this GH yet.

[rushatgabhane]

it's fixed here #34870

[alexpensify]

Thank you!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.31-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS Migration] Adjustments on KYCWall #34870

If no regressions arise, payment will be issued on 2024-02-01. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @ruben-rebelo does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[alexpensify]

@ruben-rebelo disregard my last comment here, I didn't realize you were a contractor. Sorry for the confusion on my end.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @rushatgabhane owed $500 via NewDot
• Contributor: @ruben-rebelo is from an agency-contributor and not due payment

BugZero Checklist (@alexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1747587927070720000/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[alexpensify]

No action in Upwork, I've completed the checklist above. Closing!

[rushatgabhane]

@alexpensify could you please post a payment summary for me

[alexpensify]

@rushatgabhane - it looks like there is automation for the summary and I confirmed it here:

#25126 (comment)

All set to request in NewDot!

[JmillsExpensify]

$500 approved for @rushatgabhane based on this summary.