[HOLD for payment 2023-08-16] [$1000] Inconsistency issue - No scroll bar for members page on announce room

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Create a workspace and invite more than 20 members
2. Go to announce room
3. Click on header > members

Expected Result:

There should be a scroll bar since the page is scrollable

Actual Result:

No scroll bar is shown. But there is a scroll bar present in the members page of workspace settings if the page is scrollable.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.45-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-07-25.10.42.24.mp4

Recording.1345.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690271175444019

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fa1be2257dab6e98
• Upwork Job ID: 1684630841116672000
2023-07-27
• Automatic offers:
• nathan-mulugeta | Reporter | 25862754

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency issue: No scroll bar for members page on announce room

What is the root cause of that problem?

These two lists are rendered by different components. The members' page has the scroll bar turned off explicitly here:

App/src/components/OptionsList/BaseOptionsList.js

Line 227 in e32ff5e

showsVerticalScrollIndicator={false}

What changes do you think we should make in order to solve the problem?

We should turn off the scrollbar on the WorkspaceMembersPage by passing scrollbarWidth: 'none', to the optionRow rendering the members' names:

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 325 to 328 in e32ff5e

	<OptionRow
	boldStyle
	isDisabled={disabled}
	option={{

What alternative solutions did you explore? (Optional)

We can turn on the scrollbar in the members' page by removing the prop showsVerticalScrollIndicator, but that seems to go against the design of the App, as we never show scrollbars in lists like these.

[alphaboss1104]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency issue - No scroll bar for members page on announce room

What is the root cause of that problem?

The root cause of that problem is that the showsVerticalScrollIndicator prop in React Native’s ScrollView component (which SectionList uses internally) is used to control whether to show the vertical scroll bar.

App/src/components/OptionsList/BaseOptionsList.js

Line 227 in 3d22f59

showsVerticalScrollIndicator={false}

When we set showsVerticalScrollIndicator={false}, it tells the SectionList to hide the vertical scroll bar.
By changing it to showsVerticalScrollIndicator={true}, it is telling the SectionList to display the vertical scroll bar.
So, the scroll bar visibility is controlled by this property.

What changes do you think we should make in order to solve the problem?

We can change the code from showsVerticalScrollIndicator={false} to showsVerticalScrollIndicator={true}.
However, this approach is not recommended as it goes against the principles of code reuse and modularization.
BaseOptionsList.js is the base component file so we should keep the project logic and we should avoid the side-effect.

This can be achieved by passing a new prop from ReportParticipantsPage to OptionsList and then to BaseOptionsList to control the showsVerticalScrollIndicator property.

Here’s how we can do it:

1. First, update the ReportParticipantsPage.js file to pass a new prop showScrollIndicator to OptionsList:

   <OptionsList
       sections={[
           {
               title: '',
               data: participants,
               shouldShow: true,
               indexOffset: 0,
           },
       ]}
       onSelectRow={(option) => {
           Navigation.navigate(ROUTES.getProfileRoute(option.accountID));
       }}
       hideSectionHeaders
       showTitleTooltip
       disableFocusOptions
       boldStyle
       optionHoveredStyle={styles.hoveredComponentBG}
       contentContainerStyles={[safeAreaPaddingBottomStyle]}
       showScrollIndicator={true} // Add this line
   />

2. Then, update the OptionsList.js and BaseOptionsList.js files to pass the new prop down to the SectionList component:

   • In OptionsList.js:

     <BaseOptionsList
         // eslint-disable-next-line react/jsx-props-no-spreading
         {..._.omit(props, 'forwardedRef')}
         ref={props.forwardedRef}
         onScroll={onScroll}
         showScrollIndicator={props.showScrollIndicator} // Add this line
     />

   • In BaseOptionsList.js:

     <SectionList
         ref={this.props.innerRef}
         indicatorStyle="white"
         keyboardShouldPersistTaps="always"
         keyboardDismissMode={this.props.keyboardDismissMode}
         onScrollBeginDrag={this.props.onScrollBeginDrag}
         onScroll={this.props.onScroll}
         contentContainerStyle={this.props.contentContainerStyles}
         showsVerticalScrollIndicator={this.props.showScrollIndicator} // Update this line
         sections={this.props.sections}
         keyExtractor={this.extractKey}
         stickySectionHeadersEnabled={false}
         renderItem={this.renderItem}
         getItemLayout={this.getItemLayout}
         renderSectionHeader={this.renderSectionHeader}
         extraData={this.props.focusedIndex}
         initialNumToRender={12}
         maxToRenderPerBatch={5}
         windowSize={5}
         viewabilityConfig={{viewAreaCoveragePercentThreshold: 95}}
         onViewableItemsChanged={this.onViewableItemsChanged}
     />

   We don’t forget to add the new prop to the propTypes and defaultProps of each component:

   propTypes = {
       showScrollIndicator: PropTypes.bool,
       // other props...
   };
   
   defaultProps = {
       showScrollIndicator: false,
       // other props...
   };

What alternative solutions did you explore? (Optional)

None.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fa1be2257dab6e98

[melvin-bot]

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[allroundexperts]

Thanks for your proposal @neonbhai. While you've identified the correct root cause, your solution isn't complete. I don't think that we want to directly change the css style to show the scroll bar. Your alternate solution was in the right direction but again, we can not just turn on the scroll bar for all the lists.

@alphaboss1104's proposal looks good to me as it proposes the correct solution to expose the needed prop OptionsList component.

🎀 👀 🎀 C+ reviewed

While we're at it, I see that InviteMembers page is missing the scroll bar as well. In my opinion, it makes sense to add it there as well. @johncschuster Please confirm if we should add it for that page.

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[johncschuster]

@allroundexperts good callout! There was a discussion (here) around the inclusion of scroll bars. It seems like we came to the consensus that a scroll bar should be included.

[marcochavezf]

Thanks for the review @allroundexperts, assigning @alphaboss1104 🚀

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @alphaboss1104 You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @Nathan-Mulugeta 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[alphaboss1104]

I sent proposal on Upwork and I will send the PR till tomorrow.

[johncschuster]

@alphaboss1104, @allroundexperts is the C+ Reviewer. Let's have him review it.

[alphaboss1104]

@johncschuster , @allroundexperts is already reviewed my PR and approved it.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @alphaboss1104 got assigned: 2023-07-31 18:13:32 Z
• when the PR got merged: 2023-08-03 23:52:37 UTC
• days elapsed: 3

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix no scroll bar in several pages #24116

If no regressions arise, payment will be issued on 2023-08-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligable for Manual Requests)
• @alphaboss1104 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alphaboss1104]

Can I get bonus if the C+ approved my PR (#24116) within 72 hours of assignment?

[alphaboss1104]

@johncschuster The payment date is 2023-08-16. when can I get the payment?

[alphaboss1104]

@johncschuster This is my first contribution to Expensify so I sent a proposal to the Upwork Job 3 weeks ago for getting offer.
And my upwork profile is https://www.upwork.com/freelancers/~019d30fdf312447ad4.

[Nathan-Mulugeta]

Hey @alphaboss1104, it is pretty usual for the payment date to be pushed for a few days. Internal teams will get to payment processing as soon as they get the time. And if you want the payment to be processed soon you can email [email protected] with this git hub link asking for payment to be processed and they will get back to you ASAP.

[johncschuster]

Hi @alphaboss1104, I'm sorry for missing your pings. Can you please apply to the job? Once you've applied, I will send the offer and we can get the payment taken care of.

[alphaboss1104]

Hi @JohnSchuster, Thanks for your response. I have already applied to the job.
My Upwork profile is like this.

[allroundexperts]

Checklist

1. The original implementation of BaseOptionsList did not include a scroll indicator. As such, there isn't a single PR I can point towards.
2. N/A
3. https://expensify.slack.com/archives/C049HHMV9SM/p1692648889228279
4. I think this is a really minor issue, which was hard to notice. As such, a regression test is not needed here.

[alphaboss1104]

I accepted the offer.

[johncschuster]

Payment Summary

External issue reporter - @Nathan-Mulugeta - $250
Contributor that fixed the issue - @alphaboss1104 - $1000
Contributor+ that helped on the issue and/or PR - @allroundexperts - $1000 - requested via NewDot

[johncschuster]

I have issued payment for @Nathan-Mulugeta and @alphaboss1104. @JmillsExpensify, @allroundexperts will require payment through NewDot 👍

[JmillsExpensify]

Reviewed the details for @allroundexperts. $1,000 approved for payment in NewDot based on the BZ summary above.

[MitchExpensify]

Coming from Inconsistensy Bug - vertical scroll Bar, will this issue add a vertical scroll bar in the "workspace" and "preference" page?

[MitchExpensify]

Coming from #26098 (comment), will this issue add a vertical scroll bar is not appearing in the "workspace" and "preference" page?

Curious for your take on this Q @marcochavezf 🙇

[MitchExpensify]

Should this issue be open @johncschuster ?

[johncschuster]

Good shout, @MitchExpensify! Now that payment has been issued, we're good to close this one out.