[HOLD for payment 2023-08-03] [$1000] mWeb - Horizontal message settings being displayed on mobile

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Action Performed:

1. Open a chat
2. Click with 2 fingers on 2 different message twice

Expected Result:

The comment action menu should only open on one long press on one comment

Actual Result:

The comment action menu opens when tapping quickly on separate comments

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.39.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen.mov

Screen_Recording_20230712_130622_Chrome.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @mejed-alkoutaini
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689119360544589

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e2c7a6952e9ef076
• Upwork Job ID: 1679930169256824832
• Last Price Increase: 2023-07-14

[esh-g]

Proposal

Please re-state the issue

Mini report action context menu is visible on small screen devices.

What is the root cause of that problem?

The menu is supposed to be visible when there is a hover action and mainly this is possible with a mouse, but sometimes, hover can be triggered on a click as well.

What changes do you think we should make in order to solve this problem?

In this file:

App/src/pages/home/report/ReportActionItem.js

Lines 466 to 473 in 29ae942

	<MiniReportActionContextMenu
	reportID={props.report.reportID}
	reportAction={props.action}
	isArchivedRoom={ReportUtils.isArchivedRoom(props.report)}
	displayAsGroup={props.displayAsGroup}
	isVisible={hovered && !props.draftMessage && !hasErrors}
	draftMessage={props.draftMessage}
	isChronosReport={ReportUtils.chatIncludesChronos(props.report)}

We should add !this.props.isSmallWidthScreen condition to isVisible prop with a logical AND.

What other alternative approaches did you explore?

N/A

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[esh-g]

It might be difficult to reproduce... So be sure to check the slack convo

[MitchExpensify]

This requires a physical android which I do not have, looking for another Bug Zero volunteer to take this on 👁️

[MitchExpensify]

Asked here for help https://expensify.slack.com/archives/C01SKUP7QR0/p1689200759769169

[MitchExpensify]

Clarified expected and actual here https://expensify.slack.com/archives/C049HHMV9SM/p1689201312520879?thread_ts=1689119360.544589&cid=C049HHMV9SM

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A mini context menu shows on mobile web

What is the root cause of that problem?

The mini context menu will show if the message is being hovered. The hover state is handled by the Hoverable component that depends on onMouseEnter event. In mobile web, onMouseEnter will be triggered when we simply click the component/element, but we already prevent that by disabling the hover when a touch starts.

App/src/components/Hoverable/index.js

Lines 21 to 32 in 451096b

	// we like to Block the hover on touch devices but we keep it for Hybrid devices so
	// following logic blocks hover on touch devices.
	this.disableHover = () => {
	this.hoverDisabled = true;
	};
	this.enableHover = () => {
	this.hoverDisabled = false;
	};
	document.addEventListener('touchstart', this.disableHover);
	// Remember Touchend fires before `mouse` events so we have to use alternative.
	document.addEventListener('touchmove', this.enableHover);

But then we re-enable it when setIsHovered is passed with a false value. This happens when onMouseLeave is triggered. To trigger the event, just click/press on the other message.

This works, but not reliable.

To easily reproduce it, keep clicking/pressing on multiple messages to mess up the hoverDisabled value.

Screen.Recording.2023-07-13.at.18.15.32.mov

What changes do you think we should make in order to solve the problem?

If the device doesn't support hover event, we should early return the children.

if (!DeviceCapabilities.hasHoverSupport()) return child;

then remove the hoverDisabled variable.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e2c7a6952e9ef076

[melvin-bot]

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[Santhosh-Sellavel]

@bernhardoj Proposal Looks good to me!

C+ Reviewed
🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @iwiznia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @Santhosh-Sellavel Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @bernhardoj You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @mejed! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

The BZ member will need to manually hire mejed for the Reporter role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[mejed-alkoutaini]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01fd6d1871acf14d4b

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[mejed-alkoutaini]

Why it's tagging another person! and why I always have to store my contributor details again and again, 😅 anyway I applied to the Upwork job 🙌🏻

[bernhardoj]

PR is ready

cc: @Santhosh-Sellavel

[iwiznia]

@roryabraham reassigning this to you since you already have some context and I am going on sabbatical. Feel free to ask for a fair reassignment via auto assigner

[roryabraham]

np, I can take this one 👍🏼

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @bernhardoj got assigned: 2023-07-14 23:03:26 Z
• when the PR got merged: 2023-07-26 01:10:47 UTC
• days elapsed: 7

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Disable hover on device without hover support #22925

If no regressions arise, payment will be issued on 2023-08-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment
• @Santhosh-Sellavel does not require payment (Eligable for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

• Hired @mejed-alkoutaini
• Hired @bernhardoj
• @Santhosh-Sellavel will be compensated via NewDot

Reporting: $250
C: $1000
C+: $1000 (Via NewDot to @Santhosh-Sellavel)

👍

[roryabraham]

@MitchExpensify seems like we just need to finish issuing payments here?

@Santhosh-Sellavel did you request money via NewDot?

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: Dont display tooltips on platforms that dont support hover #12168
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Dont display tooltips on platforms that dont support hover #12168 (comment)
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1691529374343869
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. N/A
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

All paid and contracts ended via Upwork!

Just waiting for confirmation of @Santhosh-Sellavel 's payment via NewDot to close this out

[Santhosh-Sellavel]

Requested on ND

[MitchExpensify]

Great, let's close this out once ND payment is confirmed!

[JmillsExpensify]

Reviewed the details for @Santhosh-Sellavel. Approved for payment in ND based on the summary from BZ above.