-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for checklist][$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money #22691
Comments
Triggered auto assignment to @greg-schroeder ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Tooltip shows only avatar and no login or display name in What is the root cause of that problem?Root cause of the problem is the new user obtained from What changes do you think we should make in order to solve the problem?So, we need to update the
and get let allPersonalDetails = {};
Onyx.connect({
key: ONYXKEYS.PERSONAL_DETAILS_LIST,
callback: (val) => {
allPersonalDetails = val;
},
}); This merges the new user’s details in What alternative solutions did you explore? (Optional)ResultScreen.Recording.2023-07-12.at.12.17.32.PM.mov |
ProposalPlease re-state the problem that we are trying to solve in this issue.Tooltip displays only avatar and 'Hmm its not here' page is displayed on visiting profile of new user during request money What is the root cause of that problem?
That's why tooltip doesn't have description.
But this What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)N/A |
I updated the OP/issue title to focus on the missing details in the user profile |
Job added to Upwork: https://www.upwork.com/jobs/~010b086092b3e04fff |
Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
ProposalPlease re-state the problem that we are trying to solve in this issue."Hmm... its not here" page is displayed when splitting a bill or requesting money from an account not interacted before What is the root cause of that problem?When we choose a contact which we have not interacted before, we create a temporary option with a random accountID that is generated by But it is an invalid accountID and not present in Line 216 in 917c344
That makes What changes do you think we should make in order to solve the problem?We can create a function in And then we should disable navigating the profile page or display not found page for the optimistic personal detail by using this function App/src/components/MoneyRequestConfirmationList.js Lines 212 to 213 in ff54c9e
App/src/components/ReportWelcomeText.js Line 104 in 98ec467
Line 1388 in 98ec467
App/src/pages/ReportParticipantsPage.js Line 117 in 98ec467
What alternative solutions did you explore? (Optional) |
@greg-schroeder I think tooltip issue here is not the same root cause with #22485 and #22062 |
@deetergp seemed to think it was per the discussion here, not sure though: https://expensify.slack.com/archives/C049HHMV9SM/p1689083906726459 |
@dukenv0307 What is preventing the ProfilePage to show users with accountID -1 ? Can we update ProfilePage to show those users? |
@sobitneupane When we select a user that is a new user in request money page, personal detail is not present in That makes Line 108 in 451096b
I don't think we can update this page to show those users because before we create request money, detail of those users doesn't in |
Can we pass some fallback data for such cases where BE is unable to send data? |
@sobitneupane Do you think about my suggestion here. |
If we want to pass some fallback, we should create an ONYXKEYS to store the fallback data. And then before we navigate to this page, we should store fallback in Onyx |
Started a discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1689247696251109 |
I think it is not good to update the ProfilePage to show users with accountID -1. |
Discussion appears to be ongoing |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.50-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-14. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-16. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Issue Participants: Issue reported by: @dhanashree-sawant ($250) There was a regression here: #22691 (comment) |
Sent payments/offers. Remaining payments will be done via NewDot. All that's left is the checklist @sobitneupane |
Not required.
Yes
|
Regression Test Proposal
Do we agree 👍 or 👎 |
Requested payment on newDot |
Thanks @sobitneupane! Took care of payments, filing regression test, closing. |
Reviewed the details for @sobitneupane. $500 approved for payment in NewDot based on BZ summary. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
App should also display user details page on click of avatar
Actual Result:
After clicking avatar, it displays 'Hmm its not here' page in request money flow
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.39-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
new.user.tooltip.and.details.page.issue.mp4
Recording.3557.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689083906726459
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: