Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-17] [Snyk] Fix for 1 vulnerabilities #22463

Closed
melvin-bot bot opened this issue Jul 8, 2023 · 15 comments
Closed

[HOLD for payment 2023-08-17] [Snyk] Fix for 1 vulnerabilities #22463

melvin-bot bot opened this issue Jul 8, 2023 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Jul 8, 2023

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 768/1000
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS)
SNYK-JS-SEMVER-3247795
Yes Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: @storybook/addon-essentials The new version differs by 250 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b12b4a3857910782
  • Upwork Job ID: 1677517705638334464
  • Last Price Increase: 2023-07-08
@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff Weekly KSv2 labels Jul 8, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Jul 8, 2023

This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.

    C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
    - [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
    - [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
    - [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes.
    - [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.

@melvin-bot
Copy link
Author

melvin-bot bot commented Jul 8, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b12b4a3857910782

@melvin-bot
Copy link
Author

melvin-bot bot commented Jul 8, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @abdulrahuman5196 (Internal)

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jul 31, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Jul 31, 2023

This issue has not been updated in over 15 days. @abdulrahuman5196 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@abdulrahuman5196
Copy link
Contributor

I will close it over this weekend

@srikarparsi srikarparsi added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 8, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 8, 2023

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Aug 8, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 8, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@srikarparsi
Copy link
Contributor

Hey @tjferriss! We need to pay @abdulrahuman5196 for reviewing a PR. @abdulrahuman5196 decided to create a new PR since there were merge conflicts but I believe the compensation remains the same.

@tjferriss
Copy link
Contributor

@abdulrahuman5196 can you please apply to the Upworks job here: https://www.upwork.com/jobs/~0142f9e7244cf14d69

@abdulrahuman5196
Copy link
Contributor

@tjferriss applied for the mentioned upwork

@tjferriss
Copy link
Contributor

The offer has been sent

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Aug 10, 2023
@melvin-bot melvin-bot bot changed the title [Snyk] Fix for 1 vulnerabilities [HOLD for payment 2023-08-17] [Snyk] Fix for 1 vulnerabilities Aug 10, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 10, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter NA
  • Contributor that fixed the issue NA
  • Contributor+ that helped on the issue and/or PR @abdulrahuman5196 $1000

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 10, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
  • [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@abdulrahuman5196] Determine if we should create a regression test for this bug.
  • [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@abdulrahuman5196
Copy link
Contributor

No BZ checklist, since this is a Synk PR merge for version updates.

@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@tjferriss
Copy link
Contributor

The payment has been sent via Upworks.

@melvin-bot melvin-bot bot removed the Overdue label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants