Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-16] [$1000] Android emulator mWeb stuck at splash screen #22395

Closed
1 task
Julesssss opened this issue Jul 7, 2023 · 47 comments
Closed
1 task
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Jul 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  • Build newDot web an unknown amount of times...
  • Open NewDot mWeb via an Android emulator Chrome app

Expected Result:

  • mWeb should run as expected

Actual Result:

  • mWeb app is stuck at the splash screen

Workaround:

Screenshot 2023-07-31 at 11 11 18

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / Chrome

Version Number: Many
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1688665141544519

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c9b138754f430c1c
  • Upwork Job ID: 1677231785028624384
  • Last Price Increase: 2023-07-31
  • Automatic offers:
    • jjcoffee | Contributor | 25898337
@Julesssss Julesssss added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Jul 7, 2023
@Julesssss Julesssss self-assigned this Jul 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 7, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01c9b138754f430c1c

@melvin-bot
Copy link

melvin-bot bot commented Jul 7, 2023

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Jul 7, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

@mananjadhav
Copy link
Collaborator

Ohh I thought it was my high traffic and low connectivity as I was travelling. After 3-4 attempts the mWeb won't load. It worked fine for me on one of my physical device, but never works on Emulator.

If I wipe data on the emulator, and reload then it works fine. Just clearing cache on Chrome didn't help either.

@slafortune
Copy link
Contributor

Is this a bug for External contributors @Julesssss ? or is this something you are looking into?

@melvin-bot melvin-bot bot added the Overdue label Jul 10, 2023
@Julesssss
Copy link
Contributor Author

@slafortune we can keep this internal 👍

@melvin-bot melvin-bot bot removed the Overdue label Jul 10, 2023
@Julesssss
Copy link
Contributor Author

Julesssss commented Jul 10, 2023

I think it's unlikely a code fix will resolve this issue, but @mananjadhav lets keep you assigned for now just in case

@melvin-bot melvin-bot bot added the Overdue label Jul 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2023

@mananjadhav, @Julesssss, @slafortune Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Julesssss Julesssss added Weekly KSv2 and removed Daily KSv2 labels Jul 14, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jul 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2023

@mananjadhav @Julesssss @slafortune this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 21, 2023
@Julesssss
Copy link
Contributor Author

Hmm, there is another issue that should resolve this one, but I can't find any link to it now 😕

@melvin-bot melvin-bot bot added the Overdue label Jul 26, 2023
@Julesssss
Copy link
Contributor Author

The other issue didn't end up resolving this.

@melvin-bot melvin-bot bot removed the Overdue label Jul 27, 2023
@Julesssss
Copy link
Contributor Author

I'll keep it for myself and look into solutions when I have a moment.

@mananjadhav
Copy link
Collaborator

do we have any insights on what's wrong? I don't see any logs in the emulator, no errors messages too?

@jjcoffee
Copy link
Contributor

jjcoffee commented Aug 1, 2023

@mananjadhav Hmm that sounds like it's probably a separate issue from what's described here and in the source Slack thread (where people report updating Chrome fixing the issue). Just to be sure are you able to check what Chrome version you have on the emulator, and also if there are any console errors (specifically key.split(...).at is not a function)?

@mananjadhav
Copy link
Collaborator

Naah I don't see this error being logged, but you're right this could be different than mine.

@Julesssss, overall I think @jjcoffee's proposal looks good.

🎀 👀 🎀 C+ Reviewed.

@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

Current assignee @Julesssss is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@Julesssss
Copy link
Contributor Author

Hmm, I'm a bit skeptical about the solution in that case. Let's try it though and see if a new bug is revealed in it's place.

@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($1000)

@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@jjcoffee
Copy link
Contributor

jjcoffee commented Aug 2, 2023

PR coming today!

@Julesssss
Copy link
Contributor Author

FYI I'm going OOO tomorrow so we'll take that into account when calculating the quick turnaround bonus

@jjcoffee
Copy link
Contributor

jjcoffee commented Aug 2, 2023

PR ready for review! cc @mananjadhav

@melvin-bot
Copy link

melvin-bot bot commented Aug 7, 2023

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

  • when @jjcoffee got assigned: 2023-08-02 08:13:40 Z
  • when the PR got merged: 2023-08-07 10:04:49 UTC
  • days elapsed: 3

On to the next one 🚀

@Julesssss
Copy link
Contributor Author

^ The bonus should apply, I was ooo for two working days.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 9, 2023
@melvin-bot melvin-bot bot changed the title [$1000] Android emulator mWeb stuck at splash screen [HOLD for payment 2023-08-16] [$1000] Android emulator mWeb stuck at splash screen Aug 9, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@mananjadhav
Copy link
Collaborator

mananjadhav commented Aug 11, 2023

In terms of checklist, I don't think we have any offending PR. Neither do we need any regression steps as it is browser compatibility issue.

@Julesssss
Copy link
Contributor Author

Yeah lets skip the checklist here, it was a dev only issue.

@mananjadhav
Copy link
Collaborator

@slafortune Can you post the payment summary here for the payout?

@slafortune
Copy link
Contributor

slafortune commented Aug 16, 2023

External issue reporter - no payment, internal report
Contributor that fixed the issue - @jjcoffee $1500 - PD
Contributor+ that helped on the issue and/or PR - @mananjadhav $1500, requested via NewDot manual requests

Speed bonus should apply, solution and pr was presented within a day.

@JmillsExpensify
Copy link

Reviewed the details for @mananjadhav. $1,500 is approved for payment in NewDot based on the summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants