Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autofocus not working if user open new task page using url #20000

Closed
1 of 6 tasks
kavimuru opened this issue Jun 1, 2023 · 13 comments
Closed
1 of 6 tasks

autofocus not working if user open new task page using url #20000

kavimuru opened this issue Jun 1, 2023 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kavimuru
Copy link

kavimuru commented Jun 1, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. open browser
  2. paste new task url (https://staging.new.expensify.com/new/task/details)

Expected Result:

should auto focus title same as when user select Assign task option from FAB

Actual Result:

auto focus does not work

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.22-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-30.at.6.28.39.PM.mov
Recording.837.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685451580697849

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 1, 2023

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 1, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@sethraj14
Copy link

@kavimuru @gadhiyamanan Not reproducible on MacOS Chrome/Brave.

@gadhiyamanan
Copy link
Contributor

@sethraj14 can you share a video

@esh-g
Copy link
Contributor

esh-g commented Jun 2, 2023

Screen.Recording.2023-06-02.at.11.48.15.AM.mov

Not able to reproduce locally

@gadhiyamanan
Copy link
Contributor

@esh-g strange I am able to reproduce it locally with latest version(v1.3.22-1)

Screen.Recording.2023-06-02.at.11.52.24.AM.mov

@alitoshmatov
Copy link
Contributor

alitoshmatov commented Jun 2, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

autofocus not working if user open new task page using url

What is the root cause of that problem?

We are not autoFocusing in initial render

What changes do you think we should make in order to solve the problem?

We should set autoFocus prop in TextInput, like we are doing in other places

<TextInput
ref={(el) => (inputRef.current = el)}
inputID="taskTitle"
label={props.translate('newTaskPage.title')}
/>

What alternative solutions did you explore? (Optional)

@sethraj14
Copy link

@gadhiyamanan @esh-g already posted the video. This issue is not reproducible on our end.

@gadhiyamanan
Copy link
Contributor

@sethraj14 @esh-g in which version have you tested because me and testing team able to reproduce #20000 (comment) #20000 (comment)

@esh-g
Copy link
Contributor

esh-g commented Jun 2, 2023

v1.3.22-1 same as you
Screenshot 2023-06-02 at 1 03 08 PM

@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mallenexpensify
Copy link
Contributor

Unable to reproduce on v1.3.24-4, staging, Chrome. Going to leave open since we're having mixed results for reproducing

2023-06-05_19-39-33.mp4

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 6, 2023
@mallenexpensify
Copy link
Contributor

Closing since I wasn't able to reproduce a few days ago nor now. Comment if you disagree
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

6 participants