[HOLD for payment 2023-05-23] [$1000] Assign Task - No focus on Description field in Assign task

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any Expensifail account
3. Go to FAB -> Assign task
4. Enter a title and NOT enter the description -> click Next
5. Open Description tab

Expected Result:

Focus present on the Description input field

Actual Result:

No focus on the Description input field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.12.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6048396_Recording__4486.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0117d4766144af9638
• Upwork Job ID: 1656000410323333120
• Last Price Increase: 2023-05-09

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Assign Task - No focus on Description field in Assign task

What is the root cause of that problem?

• The root cause is we are using autoFocus props on NewTaskDescriptionPage.js

What changes do you think we should make in order to solve the problem?

• To add autofocus to description field on NewTaskDescriptionPage.js we need to follow the below steps

• First need to create ref for the very first <TextInput> where actually we wanna focus on the screen call

• Then on <ScreenWrapper> we need to add props onEntryTransitionEnd basically these props are Called when navigated Screen's transition is finished and makes sure that keyboard opens only after the transition resulting in always successful opening keyboard with nice animation across all platform

• On simple autoFocus props we do have a common problem in that animation does not seem to work well the best approach is to add onEntryTransitionEnd

ref={el => this.InputRef = el} // Define new ref 

onEntryTransitionEnd={() => this.InputRef && this.InputRef.focus()} // focus with ref
 

What alternative solutions did you explore? (Optional)

• We can apply the same autoFocus props to NewTaskDescriptionPage.js
  but for that, we also need to pass shouldDelayFocus in order to autoFocus on Android as well seems like we have a problem on Android.

[conorpendergrast]

Reproduced, and I agree that this is a bug (it's inconsistent with how the Title, Assignee and Share somewhere pages work. I'll assume this is external, but @thienlnam , @JmillsExpensify or @shawnborton let me know if you think this should be internal.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0117d4766144af9638

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Triggered auto assignment to @luacmartins (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[thienlnam]

Yeah, let's get this handled externally! Great to introduce contributors to the Assign Task flow

[brianlee1025]

How do i create an account with assign task permission in dev env?

[s77rt]

@dhairyasenjaliya Sorry I just realised you have a proposal. Will review asap.
@brianlee1025 Can you please ask on Slack instead? (overwrite canUseTasks to return true)

[s77rt]

@dhairyasenjaliya Thanks for the proposal. Your RCA is correct (I assume you made a type we are not using autoFocus). Your suggested fix makes sense.

I noticed on NewTaskTitlePage we use autoFocus, is this broken on Android? For consistency let's either make both NewTaskTitlePage and NewTaskDescriptionPage focus the text input onEntryTransitionEnd or just add autoFocus to NewTaskDescriptionPage's text input.

🎀 👀 🎀 C+ reviewed

cc @luacmartins

[dhairyasenjaliya]

hey @s77rt technically autoFocus works, but when I was working on adding <Form> to NewContactMethod.js there we notice if we use autoFocus then there is a weird transition when opening the keyboard on both the platform Android and iOS as well, So I believe we should use onEntryTransitionEnd to both the pages and also I remember we are just changing all the autoFocus instance to use onEntryTransitionEnd for consistency throughout the ap

[s77rt]

@dhairyasenjaliya Thanks for the quick follow up. Let's go with onEntryTransitionEnd then 🚀!

[dhairyasenjaliya]

Alright waiting for assignment then will create PR soon @s77rt

[dhairyasenjaliya]

Awaiting for assignment @luacmartins

[melvin-bot]

📣 @dhairyasenjaliya You have been assigned to this job by @luacmartins!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[s77rt]

Not overdue. PR is in draft status.

[dhairyasenjaliya]

@s77rt PR ready for review
BTW are you facing any login issues on localhost chrome ?

[s77rt]

@dhairyasenjaliya Thanks for the PR

No, all seems good from my side. Try clear onyx storage if the issue still persists please ask on slack.

[conorpendergrast]

I've just sent offers via Upwork, held on deploy and 7-day regression period.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Task auto focus fix #18889

If no regressions arise, payment will be issued on 2023-05-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - N/A - Applause
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Create Task FrontEnd Changes #17992
• The offending PR has been commented on: Create Task FrontEnd Changes #17992 (comment)
• A discussion in #expensify-bugs has been started: https://expensify.slack.com/archives/C049HHMV9SM/p1684326161989029
• Determine if we should create a regression test for this bug: No

[conorpendergrast]

Pay day, moving to Daily

[conorpendergrast]

Looks like this qualifies for the urgency bonus too! Adding +50% and paying

[conorpendergrast]

Paid, contracts ended, checklist completed. All done, and closing!