[HOLD on #16506] [$1000] Double-tapping on an existing emoji reaction sends multiple API requests

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. On Account A, open a chat and react to any message with an emoji.
2. On Account B, open the same chat and find the message with the emoji reaction.
3. On Account B, double-click on the emoji reaction that you added from Account A.

Expected result:

The emoji reaction should toggle between added and removed. Only one API request should be sent per click

Actual result:

The emoji reaction remains added after double-clicking. Multiple API requests are sent per click

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

az_recorder_20230425_125454.1.mp4

Screen_Recording_20230423_133244_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682247959692439

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f007b9fd26168fd7
• Upwork Job ID: 1651889136408948736
• Last Price Increase: 2023-05-30

[MelvinBot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[twisterdotcom]

Yup, this is odd: https://drive.google.com/file/d/1_4hEFTXBd781XpDNDIv7J0f4KWbjZh3X/view?usp=sharing

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01f007b9fd26168fd7

[MelvinBot]

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[MelvinBot]

Triggered auto assignment to @yuwenmemon (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Double-tapping on an existing emoji reaction sends multiple API requests

What is the root cause of that problem?

The emoji reaction button is based on Pressable component. Currently we don't neither disable button nor prevent user click multiple time that button.

What changes do you think we should make in order to solve the problem?

We have general solution here #18122
So we can wait until this PR merge. Then we can replace Pressable by PressableWithFeedback which will prevent multiple click on a pressable element.

I have tried InteractionManager.runAfterInteractions but it seems it doesn't work in this case. I couldn't prove but It seems the action Report.toggleEmojiReaction is not heavy, it runs fast so what we have here doesn't fit. And the InteractionManager.runAfterInteractions only ensure a function to run after all interactions have completed. It doesn't mean to ensure it prevents double click.

I think we can go with debounce. I tried with debounce 250ms here and it works well

Screen.Recording.2023-06-04.at.21.26.41.mov

[mollfpr]

Thanks @hoangzinh!

@yuwenmemon @twisterdotcom #18122 is about creating a new button component and preventing multiple clicks. So it makes sense to hold this and try the above proposal.

[yuwenmemon]

Sounds good - place a hold on this and switched it to Weekly

[twisterdotcom]

Still on hold.

[twisterdotcom]

I don't have my android phone with me at the moment. I see #18122 hit production. @mollfpr or @yuwenmemon - can you test and see if we can just close this?

[twisterdotcom]

How are we doing here?

[mollfpr]

Sorry for the delay!

@hoangzinh I just try replacing PressableWithSecondaryInteraction with PressableWithFeedback but the issue is still reproduced. Could you update your proposal with the latest solution?

[hoangzinh]

@mollfpr I will try to update my proposal again. Last time, I also weren't success on applying PressableWithFeedback

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[twisterdotcom]

No Melv. @hoangzinh is on the case.

[hoangzinh]

I have updated my proposal here #17978 (comment)
Please help me to review it. Thanks

[stitesExpensify]

I think that we should put this on hold for now https://expensify.slack.com/archives/C049HHMV9SM/p1685714808977889?thread_ts=1685548338.234339&cid=C049HHMV9SM

#16506

[yuwenmemon]

Issue is still on HOLD

[twisterdotcom]

Still on HOLD

[twisterdotcom]

Still on hold.

[stitesExpensify]

I can't reproduce this anymore. Can anyone else?

[Nathan-Mulugeta]

Yeah I just retested and this issue is for sure no longer reproducible.