[HOLD for payment 2023-02-13] [$1000] Web - Payment - The welcome message in Spanish not centered

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Preconditional: profile language is Spanish

1. Go to URL https://staging.new.expensify.com/
2. Login with any profile
3. Go to Settings -> Payments -> Add any payment method

Expected Result:

The welcome message is centered

Actual Result:

The welcome message in NOT centered

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Win / Chrome
• MacOS / Desktop

Version Number: 1.2.63.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01384da887bf662724
• Upwork Job ID: 1620921009835147264
• Last Price Increase: 2023-02-02

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01384da887bf662724

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

[strepanier03]

Will follow along with the PR and take appropriate steps when applicable.

[melvin-bot]

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

[melvin-bot]

Upwork job price has been updated to $1000

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.65-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Center header text in confirmation page #14738

If no regressions arise, payment will be issued on 2023-02-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - Internal/Applause reported, no bug reporter pay out
• Contributor that fixed the issue - Fixed by internal engineer, no contributor pay out
• Contributor+ that helped on the issue and/or PR - $1000 for @Santhosh-Sellavel
• Note: The speed bonus does not apply here.

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel / @luacmartins] The PR that introduced the bug has been identified. Link to the PR: Add confirmation page #13744
• [@Santhosh-Sellavel / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add confirmation page #13744 (comment)
• [@Santhosh-Sellavel / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed I guess, @luacmartins can you confirm though?
• [@Santhosh-Sellavel] Propose regression test steps to ensure the same bug will not reach production again.
  Steps [HOLD for payment 2023-02-13] [$1000] Web - Payment - The welcome message in Spanish not centered #14734 (comment)
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: Do nothing due to internationalization not being rolled out yet.

[strepanier03]

I updated the payout checklist above and will work on the reg test assessment.

[strepanier03]

I just realized the proposal for the reg test is actually on @Santhosh-Sellavel, I missed that we updated that step. I'll follow along for your assessment and the other answers to the checklist. Thank you!

[Santhosh-Sellavel]

Test Steps From PR itself looks good to me thoughts @strepanier03 & @luacmartins

Tests

1. Navigate to Settings > Preferences and change the language to Spanish

2. Navigate to Settings > Payments > Add bank account

3. Select Citi and enter user_good and pass_good as credentials

4. Select an account

5. Verify that the Cuenta bancaria personal añadida text is centered

[luacmartins]

I think those steps look good, but I'm not sure that we are adding internationalization steps to TestRail since that's behind a beta and is not a supported feature yet. I'd check with Applause on this one.

[strepanier03]

I'm pretty sure you're right @luacmartins. The last time I had an internationalization GH we did nothing for the regression test but I'll confirm with Applause and either make the GH or check off that part of the BZ checklist.

[luacmartins]

Sounds good! Thanks for checking @strepanier03!

[strepanier03]

@Santhosh-Sellavel - Could you please reply with answers to the checklist items here? Once we have that info I can update the checklist and pay out the job in Upwork. Thank you!

[Santhosh-Sellavel]

• [@Santhosh-Sellavel / @luacmartins] The PR that introduced the bug has been identified. Link to the PR: Add confirmation page #13744
• [@Santhosh-Sellavel / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add confirmation page #13744 (comment)
• [@Santhosh-Sellavel / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed I guess, @luacmartins can you confirm though?
• [@Santhosh-Sellavel] Propose regression test steps to ensure the same bug will not reach production again.
  Steps here

@strepanier03

[strepanier03]

Thank you @Santhosh-Sellavel, very much appreciated! I've sent you an invite on the job, my apologies for not doing that before I didn't realize it was created as a private job.

[strepanier03]

I'll check back again at the end of my day and if the invite and offer is accepted by then I'll pay out in Upwork.

[Santhosh-Sellavel]

@strepanier03 Accepted the invite, In case you are not aware, there is an option to hire straightaway instead of inviting first and followed by hiring. Let me know once the offer is sent thanks!

[strepanier03]

Oh thank you for the heads up @Santhosh-Sellavel - I'll look that up in their help docs, I didn't know about it!

You're paid out by the way, 👋 thanks for your hard work on this.