[HOLD for payment 2023-02-18] [$2000] Payment method actions doesn’t get dismissed when payment method deleted from different device

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to payment methods page in 2 devices
2. On first device click on the payment method so that ‘Delete’ or ‘Make default payment’ popup shows up
3. Now delete the payment method from the second device

Expected Result

As payment method is removed, the popup should also dismiss

Actual Result

The payment method is removed but the popup is not removed and even allowing to enter password.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.58-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-01-24.at.11.03.12.PM.mov

Recording.77.mp4

Expensify/Expensify Issue URL:
Issue reported by: @abdulrahuman5196
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674584214326729

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01721c4a575a5223ab
• Upwork Job ID: 1618785375281623040
• Last Price Increase: 2023-02-03

[sophiepintoraetz]

Bug0 Triage Checklist

Note: see this SO for more information.

• The "bug" is actually a bug
• The bug is not a duplicate report of an existing GH.
  • If it is, close the GH and add any novel details to the original GH instead
• The bug is reproducible, following the reproduction steps.
  • If the GH doesn’t have steps to reliably reproduce the bug and you figure it out, then please add them.
  • If you’re unable to reproduce the bug, add the Needs reproduction label.
  • Comment on the issue outlining the steps you took to try to reproduce the bug, your results and tag the issue reporter and the Applause QA member who created the issue. Ask them to clarify reproduction steps and/or to check the reproduction steps again. Close issue.
• The GH template is filled out as fully as possible
  • The GH body and title are clear (ie. could an external contributor understand it and work on it?)
• The GH was created by an Expensify employee or a QA tester
• If the bug is an OldDot issue, you should decide whether it is widespread enough to justify fixing or it is better to wait for reunification. If it’s better to wait, close the GH & provide this justification
• If there's a link to Slack, check the discussion to see if we decided not to fix it
• Decide if the GH should be resolved by an External contributor or Internal engineer, add the appropriate label

[sophiepintoraetz]

I was able to reproduce this - the pop up did not disappear for me.

[PauloGasparSv]

Will test what happens if you try deleting or setting the default password on that state to make sure this is something we want to fix or not and maybe start a discussion on #expensify-open-source

[PauloGasparSv]

Tested here and I do think we need to fix this!
If we attempt to delete an account that is already deleted, an non-dismissible error appears and an empty bank account appears in the list.

Marking this as External.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01721c4a575a5223ab

[melvin-bot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[melvin-bot]

Current assignee @PauloGasparSv is eligible for the External assigner, not assigning anyone new.

[abdulrahuman5196]

I was the reporter and made initial proposal as part of slack report itself - https://expensify.slack.com/archives/C049HHMV9SM/p1674648521989299?thread_ts=1674584214.326729&cid=C049HHMV9SM
Proposal
Root Cause
We are not updating the local states to dismiss the modals when the payment method is deleted in another device and we receive pusher notification.
Solution 1

index df20970bf2..56791d56a8 100644
--- a/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js
+++ b/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js
@@ -86,6 +86,18 @@ class BasePaymentsPage extends React.Component {
         } else {
             this.debounceSetShouldShowLoadingSpinner();
         }
+        if (this.state.shouldShowDefaultDeleteMenu || this.state.shouldShowPasswordPrompt) {
+            if ((this.props.bankAccountList !== prevProps.bankAccountList && !_.find(this.props.bankAccountList, paymentMethod => paymentMethod.methodID === this.state.methodID))
+            || (this.props.cardList !== prevProps.cardList && !_.find(this.props.cardList, paymentMethod => paymentMethod.methodID === this.state.methodID))
+            || (this.props.payPalMeData !== prevProps.payPalMeData && prevProps.payPalMeData.methodID === this.state.methodID)) {
+                if (this.state.shouldShowDefaultDeleteMenu) {
+                    this.hideDefaultDeleteMenu();
+                }
+                if (this.state.shouldShowPasswordPrompt) {
+                    this.hidePasswordPrompt();
+                }
+            }
+        }
 
         // previously online OR currently offline, skip fetch
         if (!prevProps.network.isOffline || this.props.network.isOffline) {
@@ -518,6 +530,9 @@ export default compose(
         cardList: {
             key: ONYXKEYS.CARD_LIST,
         },
+        payPalMeData: {
+            key: ONYXKEYS.PAYPAL,
+        },
         walletTerms: {
             key: ONYXKEYS.WALLET_TERMS,
         },

Solution 2

--- a/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js
+++ b/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js
@@ -86,6 +86,21 @@ class BasePaymentsPage extends React.Component {
         } else {
             this.debounceSetShouldShowLoadingSpinner();
         }
+        if (this.state.shouldShowDefaultDeleteMenu || this.state.shouldShowPasswordPrompt) {
+            if ((this.props.bankAccountList !== prevProps.bankAccountList
+                || this.props.cardList !== prevProps.cardList
+                || this.props.payPalMeData !== prevProps.payPalMeData)
+                && !_.find(PaymentUtils.formatPaymentMethods(this.props.bankAccountList, this.props.cardList, this.props.payPalMeData),
+                    paymentMethod => paymentMethod.methodID === this.state.methodID)) {
+                if (this.state.shouldShowDefaultDeleteMenu) {
+                    this.hideDefaultDeleteMenu();
+                }
+                if (this.state.shouldShowPasswordPrompt) {
+                    this.hidePasswordPrompt();
+                }
+            }
+        }
 
         // previously online OR currently offline, skip fetch
         if (!prevProps.network.isOffline || this.props.network.isOffline) {
@@ -518,6 +533,9 @@ export default compose(
         cardList: {
             key: ONYXKEYS.CARD_LIST,
         },
+        payPalMeData: {
+            key: ONYXKEYS.PAYPAL,
+        },
         walletTerms: {
             key: ONYXKEYS.WALLET_TERMS,
         },

Add-ons we can do

• We can reset stale state values set during payment method onpress functionality to make the solution fool proof - https://github.com/Expensify/App/blob/main/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js#L181-L188, We should also reset the states at hideDefaultDeleteMenu(), hidePasswordPrompt() and other places as optimization in the code.
• The solution covers all payment methods like bankAccounts, cardList and paypal. I don't think any other method exists, if they do we can add the same to the above check.
• We can also do the similar solution in PaymentMethodList.js and pass the information back to BasePaymentsPage.js but it wouldn't be best practice as BasePaymentsPage.js is handling the model display
• I have compared payment method uniqueness with methodID, we also do with other information like accountNumber, but methodID seems uniform
• We can also check if the payment method is present before calling respective delete functions in https://github.com/Expensify/App/blob/main/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js#L273 similarly for makeDefaultPaymentMethod as well here https://github.com/Expensify/App/blob/main/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js#L256
• We can also filter payment methods with only errors or invalid state from being shown in list page as empty rows by adding it to filter here - https://github.com/Expensify/App/blob/main/src/pages/settings/Payments/PaymentMethodList.js#L121
• We can add object indexing find there instead of array find and use selected payment type to filter out payment methods.

[ebergolla]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

1. Go to payment methods page in 2 devices

2. On first device click on the payment method so that ‘Delete’ or ‘Make default payment’ popup shows up

3. Now delete the payment method from the second device

Expected Result

As payment method is removed, the popup should also dismiss

Actual Result

The payment method is removed but the popup is not removed and even allowing to enter password.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

* [ ]  Android / native

* [ ]  Android / Chrome

* [x]  iOS / native

* [ ]  iOS / Safari

* [x]  MacOS / Chrome / Safari

* [ ]  MacOS / Desktop

Version Number: 1.2.58-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Screen.Recording.2023-01-24.at.11.03.12.PM.mov
Recording.77.mp4

Expensify/Expensify Issue URL: Issue reported by: @abdulrahuman5196 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674584214326729

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Proposal

I would add the necessary code to read when prop cardList changes in component BasePaymentPage, if this prop changes I would check if the payment method(selected to delete or set as default) still exists, if not I would change the state "shouldShowDefaultDeleteMenu" in BasePaymentPage component to false that way it would hide the "popup".

Thanks,
Ernesto

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[DavidGOD228]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

1. Go to payment methods page in 2 devices
2. On first device click on the payment method so that ‘Delete’ or ‘Make default payment’ popup shows up
3. Now delete the payment method from the second device

Expected Result

As payment method is removed, the popup should also dismiss

Actual Result

The payment method is removed but the popup is not removed and even allowing to enter password.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.58-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:

Screen.Recording.2023-01-24.at.11.03.12.PM.mov
Recording.77.mp4
Expensify/Expensify Issue URL: Issue reported by: @abdulrahuman5196 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674584214326729

View all open jobs on GitHub

Upwork Automation - Do Not Edit

PROPOSAL:
As I see final solution should look like.

• We have an event that updates the list of accounts after deletion, we run a listener that will wait for the deletion
• After the deletion event works, check the following conditions:

1. We have an open modal window
2. A modal window is open for the account that was deleted
   If the condition is true, we remove the buttons in the modal window and insert the appropriate text there

In the code it'll be:
This listener should be in BasePaymentPage.js and it should trigger this.hideDefaultDeleteMenu(); and show text alert to user.
Best,
David

[melvin-bot]

📣 @abdulrahuman5196 You have been assigned to this job by @PauloGasparSv!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[abdulrahuman5196]

@PauloGasparSv @0xmiroslav
PR is ready for this issue - #14869
Should be a Quick PR as the change is same as the commit diff reviewed

Quick Tip: I usually have the test account logged-in on a incognito tab to quickly add test payment methods as soon as i delete. This helps to quickly verify the fix in multiple platforms.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Removing payment method actions model when payment method is removed from another device #14869

If no regressions arise, payment will be issued on 2023-02-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav / @PauloGasparSv] The PR that introduced the bug has been identified. Link to the PR: Add default/delete popover and supporting methods #4437
• [@0xmiroslav / @PauloGasparSv] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add default/delete popover and supporting methods #4437 (comment)
• [@0xmiroslav / @PauloGasparSv] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think there is a need for that, this was an overlooked detail in the Design Doc and implementation of that feature and not in the P.R. itself.
• [@abdulrahuman5196] Propose regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abdulrahuman5196]

Regression Test

1. Login to same account in 2 different devices(primary and secondary)
2. Go to payment methods page on primary device
3. On primary device click on a payment method so that ‘Delete’ or ‘Make default payment’ popup shows up.
4. Now go to payment methods page on secondary device
5. Delete the payment method from the secondary device which was selected on the primary device.
6. Now on primary device the popup should have been dismissed and the payment method should have been removed from the list.

[abdulrahuman5196]

@sophiepintoraetz Gentle remainder. This issue has passed 7 days regression timeframe. I have applied for the upwork job as well.

[sophiepintoraetz]

@abdulrahuman5196 - please don't bump the GH for payment unless there's been a significant time lapse (I'm talking weeks). We have our own method for keeping track of payments (see the daily label vs weekly) and considering the 18th is a weekend for me, there wasn't going to be an opportunity until today.

[sophiepintoraetz]

Actually, don't mind me - I miscalculated the bonus @abdulrahuman5196!

@0xmiroslav - your payment is $3000, I believe - are you able to apply for the job?

Job hire list for me

[abdulrahuman5196]

@sophiepintoraetz Accepted the upwork offer.

[0xmiros]

@0xmiroslav - your payment is $3000, I believe - are you able to apply for the job?

@sophiepintoraetz Applied for the job

[sophiepintoraetz]

Moving back to weekly now that payment/hiring has been issued.

[sophiepintoraetz]

QA here

@0xmiroslav and @PauloGasparSv - please can you complete the steps in this comment here and close the issue once you've done so?