[Hold for payment 01-02-2023] [$1000] Tooltip is not in the center while hovering on a profile pic #13940

kavimuru · 2023-01-02T21:00:27Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Open any chat
hover mouse on profile pic

Expected Result:

tooltip should be in center of profile pic

Actual Result:

tooltip is not in the center

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Web / Chrome / Safari

Version Number: 1.2.47-0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1672221180234109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e3f915ebae1ec606
Upwork Job ID: 1610419163878563840
Last Price Increase: 2023-01-03

trjExpensify · 2023-01-03T23:33:33Z

I can repro this reliably, moving external.

melvin-bot · 2023-01-03T23:33:46Z

Job added to Upwork: https://www.upwork.com/jobs/~01e3f915ebae1ec606

melvin-bot · 2023-01-03T23:33:48Z

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-01-03T23:33:55Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

melvin-bot · 2023-01-03T23:33:59Z

Triggered auto assignment to @bondydaa (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Pujan92 · 2023-01-03T23:34:35Z

Proposal

Issue is occuring due to the margin applies to the child component of the Tooltip.
To fix we need to apply margin right to the Pressable(parent component of tooltip).

diff --git a/src/pages/home/report/ReportActionItemSingle.js b/src/pages/home/report/ReportActionItemSingle.js
index a4958ab1b..4ad15b159 100644
--- a/src/pages/home/report/ReportActionItemSingle.js
+++ b/src/pages/home/report/ReportActionItemSingle.js
@@ -66,7 +66,7 @@ const ReportActionItemSingle = (props) => {
     return (
         <View style={props.wrapperStyles}>
             <Pressable
-                style={styles.alignSelfStart}
+                style={[styles.alignSelfStart, styles.mr2]}
                 onPressIn={ControlSelection.block}
                 onPressOut={ControlSelection.unblock}
                 onPress={() => showUserDetails(props.action.actorEmail)}
diff --git a/src/styles/styles.js b/src/styles/styles.js
index b3de12803..f4d161c59 100644
--- a/src/styles/styles.js
+++ b/src/styles/styles.js
@@ -695,7 +695,6 @@ const styles = {
     // Actions
     actionAvatar: {
         borderRadius: 20,
-        marginRight: 8,
     },

We can replace borderRadius: 20 with the variable too.
borderRadius: variables.componentBorderRadiusRounded

bondydaa · 2023-01-03T23:53:42Z

This seems okay though I think it does end up making the profile pictures ever so slightly smaller as well

cc @shawnborton thoughts?

bondydaa · 2023-01-04T00:01:31Z

oh wait no nevermind it's not smaller, zooming in on that and using something for guide they're the same size

👍

bondydaa · 2023-01-04T00:05:23Z

Will wait for the C+ to confirm as well

Pujan92 · 2023-01-04T04:20:18Z

@bondydaa Currently that avatar contains the right margin which increases the width of the Tooltip area and due to that center of the area is a bit right and not within the center of the avatar.

shawnborton · 2023-01-04T09:54:05Z

I'm not sure at what point this changed but there should be 12px margin (not 8px) in between the avatar and the name/message. We could fix that here or we could save that for a new issue.

shawnborton · 2023-01-04T10:10:56Z

Actually sorry, let's tackle the extra margin as a separate issue - I think there are other implications here we need to consider beyond the tooltip so I don't want to bloat the original issue at hand. Sorry about that!

Pujan92 · 2023-01-04T10:37:55Z

Yes, 12px for particular this case will shift the content more to the right which will be inconsistent with the other messages alignment and requires a fix at other places too.

Puneet-here · 2023-01-04T10:50:21Z

Proposal

This issue is present for name tooltip too.

to fix it we need to remove the padding from below

App/src/styles/styles.js

Lines 1315 to 1316 in 034a6f0

    
           paddingRight: 5, 
        
           paddingBottom: 4,

Add the padding styles below

App/src/pages/home/report/ReportActionItemSingle.js

Line 85 in 034a6f0

style={[styles.flexShrink1]}

To fix the avatar tooltip issue we need to add styles.mr2 below

App/src/pages/home/report/ReportActionItemSingle.js

Line 69 in 034a6f0

style={styles.alignSelfStart}

and remove margin here

App/src/styles/styles.js

Line 698 in 034a6f0

marginRight: 8,

Pujan92 · 2023-01-04T10:57:57Z

@shawnborton just to correct the current margin in the LHN for avatar and name is 16px.

To make the same 16px margin for the messages we can apply below changes.

diff --git a/src/pages/home/report/ReportActionItemSingle.js b/src/pages/home/report/ReportActionItemSingle.js
index a4958ab1b..fdb1464be 100644
--- a/src/pages/home/report/ReportActionItemSingle.js
+++ b/src/pages/home/report/ReportActionItemSingle.js
@@ -66,7 +66,7 @@ const ReportActionItemSingle = (props) => {
     return (
         <View style={props.wrapperStyles}>
             <Pressable
-                style={styles.alignSelfStart}
+                style={[styles.alignSelfStart, styles.mr4]}
                 onPressIn={ControlSelection.block}
                 onPressOut={ControlSelection.unblock}
                 onPress={() => showUserDetails(props.action.actorEmail)}
diff --git a/src/styles/styles.js b/src/styles/styles.js
index 82e9ca8f2..4005ff276 100644
--- a/src/styles/styles.js
+++ b/src/styles/styles.js
@@ -695,7 +695,6 @@ const styles = {
     // Actions
     actionAvatar: {
         borderRadius: 20,
-        marginRight: 8,
     },
 
     componentHeightLarge: {
@@ -1289,7 +1288,7 @@ const styles = {
         flexShrink: 1,
         flexBasis: 0,
         position: 'relative',
-        marginLeft: 48,
+        marginLeft: 56,
     },

Pujan92 · 2023-01-04T11:25:09Z

@shawnborton just to correct the current margin in the LHN for avatar and name is 16px.

But to make it consistent we need to apply changes to the display user time line and in the composer input too, which seems to be the reason to me why it is 8px.

umair-upwork · 2023-01-04T11:34:29Z

Proposal

Problem

This issue is occurring because of the margin added to the <Avatar> with styles.actionAvatar, which has a marginRight of 8. The <Avatar>is inside of the <Tooltip>, so adding a marginRight to <Avatar> also adds some margin to <Tooltip>, causing it to shift to the right instead of remaining centered.

App/src/pages/home/report/ReportActionItemSingle.js

Lines 75 to 76 in 034a6f0

    
           <Avatar 
        
               containerStyles={[styles.actionAvatar]}

Solution

We can remove styles.actionAvatar from <Avatar> in

App/src/pages/home/report/ReportActionItemSingle.js

Lines 75 to 76 in 034a6f0

    
           <Avatar 
        
               containerStyles={[styles.actionAvatar]}

and add it to <Pressable style={[styles.alignSelfStart, styles.actionAvatar]}> in

App/src/pages/home/report/ReportActionItemSingle.js

Lines 68 to 69 in 034a6f0

    
           <Pressable 
        
               style={styles.alignSelfStart}

Now, if we add any margin value to it in

App/src/styles/styles.js

Lines 696 to 699 in 034a6f0

    
           actionAvatar: { 
        
               borderRadius: 20, 
        
               marginRight: 8, 
        
           },

Tooltip will always remain centered while hovering on a profile pic or name

Demo

Screen.Recording.2023-01-04.at.4.32.00.PM.mov

syedsaroshfarrukhdot · 2023-01-04T13:29:08Z

Proposal :-

The same issue is being replicated for name as highlighted by @Puneet-here

As there are multiple ways to solve it I find this solution to be best working if we in future we need to change paddings for either item for name and avatar Tooltip position won't be affected it will be always be centered for both name and avatar.

We can pass avatar style to presssable and marginLeft : 5 To ReportActionItemDate

diff --git a/src/pages/home/report/ReportActionItemDate.js b/src/pages/home/report/ReportActionItemDate.js
index 0cf570132..02e928cf9 100644
--- a/src/pages/home/report/ReportActionItemDate.js
+++ b/src/pages/home/report/ReportActionItemDate.js
@@ -13,7 +13,7 @@ const propTypes = {
 };
 
 const ReportActionItemDate = props => (
-    <Text style={[styles.chatItemMessageHeaderTimestamp]}>
+    <Text style={[styles.chatItemMessageHeaderTimestamp, {...props.style}]}>
         {props.datetimeToCalendarTime(props.created)}
     </Text>
 );
diff --git a/src/pages/home/report/ReportActionItemSingle.js b/src/pages/home/report/ReportActionItemSingle.js
index a4958ab1b..980208df2 100644
--- a/src/pages/home/report/ReportActionItemSingle.js
+++ b/src/pages/home/report/ReportActionItemSingle.js
@@ -66,14 +66,13 @@ const ReportActionItemSingle = (props) => {
     return (
         <View style={props.wrapperStyles}>
             <Pressable
-                style={styles.alignSelfStart}
+                style={[styles.alignSelfStart, styles.actionAvatar]}
                 onPressIn={ControlSelection.block}
                 onPressOut={ControlSelection.unblock}
                 onPress={() => showUserDetails(props.action.actorEmail)}
             >
                 <Tooltip text={props.action.actorEmail}>
                     <Avatar
-                        containerStyles={[styles.actionAvatar]}
                         source={avatarUrl}
                     />
                 </Tooltip>
@@ -98,7 +97,7 @@ const ReportActionItemSingle = (props) => {
                                 />
                             ))}
                         </Pressable>
-                        <ReportActionItemDate created={props.action.created} />
+                        <ReportActionItemDate created={props.action.created} style={{marginLeft : 5}}/>
                     </View>
                 ) : null}
                 {props.children}
diff --git a/src/styles/styles.js b/src/styles/styles.js
index 82e9ca8f2..be7715143 100644
--- a/src/styles/styles.js
+++ b/src/styles/styles.js
@@ -1312,7 +1312,6 @@ const styles = {
         fontSize: variables.fontSizeNormal,
         fontWeight: fontWeightBold,
         lineHeight: variables.lineHeightXLarge,
-        paddingRight: 5,
         paddingBottom: 4,
         ...wordBreak.breakWord,
     },

After Fix :-

Screen.Recording.2023-01-04.at.6.15.07.PM.mov

daraksha-dk · 2023-01-04T19:29:10Z

coming from here

Proposal

I found this tooltip not being centered issue throughout the app and compiled a list of changes to fix all of them.

There are two main sections where this issue resides:

1. for Header buttons

Places where HeaderWithCloseButton is being used
IOUModal

Changes that needs to be done:

Adding a View Container with style prop having styles.mr2 as value and setting styles.mr0 for the Pressable Component below:

App/src/components/HeaderWithCloseButton.js

Lines 141 to 155 in 034a6f0

    
           {this.props.shouldShowBackButton && ( 
        
               <Tooltip text={this.props.translate('common.back')}> 
        
                   <Pressable 
        
                       onPress={() => { 
        
                           if (this.props.isKeyboardShown) { 
        
                               Keyboard.dismiss(); 
        
                           } 
        
                           this.props.onBackButtonPress(); 
        
                       }} 
        
                       style={[styles.touchableButtonImage]} 
        
                   > 
        
                       <Icon src={Expensicons.BackArrow} /> 
        
                   </Pressable> 
        
               </Tooltip> 
        
           )}

Doing the same for download button here

App/src/components/HeaderWithCloseButton.js

Lines 161 to 176 in 034a6f0

    
           { 
        
               this.props.shouldShowDownloadButton && ( 
        
               <Tooltip text={this.props.translate('common.download')}> 
        
                   <Pressable 
        
                       onPress={this.triggerButtonCompleteAndDownload} 
        
                       style={[styles.touchableButtonImage]} 
        
                   > 
        
                       <Icon 
        
                           src={Expensicons.Download} 
        
                           fill={StyleUtils.getIconFillColor(getButtonState(false, false, this.props.isDelayButtonStateComplete))} 
        
                       /> 
        
                   </Pressable> 
        
               </Tooltip> 
        
               ) 
        
           }

Although I think the download button doesn't need extra margin of 8px in the right as in all the other places the buttons are right next to each other without extra padding/margin. Will confirm this with @shawnborton at the bottom.

Same changes for the IOUModal here

App/src/pages/iou/IOUModal.js

Lines 380 to 390 in 034a6f0

    
           {this.state.currentStepIndex > 0 
        
               && ( 
        
                   <Tooltip text={this.props.translate('common.back')}> 
        
                       <TouchableOpacity 
        
                           onPress={this.navigateToPreviousStep} 
        
                           style={[styles.touchableButtonImage]} 
        
                       > 
        
                           <Icon src={Expensicons.BackArrow} /> 
        
                       </TouchableOpacity> 
        
                   </Tooltip> 
        
               )}

Another way to solve these problems (IMO Better):

We can just remove line no. 525 from here and make the rest of the changes accordingly because in all the other places where this style is being used we're eventually resetting the margin-right value by using styles.mr0

App/src/styles/styles.js

Lines 521 to 527 in 034a6f0

    
           touchableButtonImage: { 
        
               alignItems: 'center', 
        
               height: variables.componentSizeNormal, 
        
               justifyContent: 'center', 
        
               marginRight: 8, 
        
               width: variables.componentSizeNormal, 
        
           },

2. for Avatar and Name tooltips

Changes

Remove these lines of code:

App/src/styles/styles.js

Lines 1315 to 1316 in 034a6f0

    
           paddingRight: 5, 
        
           paddingBottom: 4,

App/src/styles/styles.js

Line 698 in 034a6f0

marginRight: 8,

paddingRight:5,
paddingBottom: 4,

Create a new object with above styles and pass below:

App/src/pages/home/report/ReportActionItemSingle.js

Line 85 in 034a6f0

style={[styles.flexShrink1]}

And add styles.mr2 to

App/src/pages/home/report/ReportActionItemSingle.js

Line 69 in 034a6f0

style={styles.alignSelfStart}

Places where the buttons are stacked right next to each other without any spacing :

The only place where a gap of 8px is observed

Just want to confirm if this is intentional or need to be fixed.
cc: @shawnborton

Pujan92 · 2023-01-04T20:32:35Z

Just to make a point, the items mentioned by the other contributors are suggestions and improvements which is not directly related to the raised issue. I definitely agree that these are the bugs that can be raised in the future and solving them now is a good step but I believe the first valid proposal for the raised issue needs to be considered and should get a chance to incorporate these changes(all tooltip positional) if we are planning for it.

Pujan92 · 2023-01-06T06:48:42Z

PR is ready for review.

Puneet-here · 2023-01-13T17:09:27Z

Hi, I wanted to confirm if I am eligible for compensation since I mentioned a new instance of this issue and proposed a solution which was used. Like here.

melvin-bot · 2023-01-13T18:28:41Z

@bondydaa, @eVoloshchak, @Pujan92, @trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

eVoloshchak · 2023-01-13T18:41:48Z

Not overdue, PR was deployed to production 3 days ago
Weird, there is no Overdue label

jatinsonijs · 2023-01-19T12:29:06Z

@Pujan92 this issue still exist

Pujan92 · 2023-01-19T12:39:51Z

Ohh, seems this PR from @grgia overwritten changes which I did for this fix. The right margin which we applied to the parent element is applied again within the child in that PR which causes the issue. @bondydaa @eVoloshchak needed the below change to apply 12px margin between avatar and name.

diff --git a/src/pages/home/report/ReportActionItemSingle.js b/src/pages/home/report/ReportActionItemSingle.js
index bb1d39e62..c90335a9d 100644
--- a/src/pages/home/report/ReportActionItemSingle.js
+++ b/src/pages/home/report/ReportActionItemSingle.js
@@ -73,7 +73,7 @@ const ReportActionItemSingle = (props) => {
     return (
         <View style={props.wrapperStyles}>
             <Pressable
-                style={[styles.alignSelfStart]}
+                style={[styles.alignSelfStart, styles.mr3]}
                 onPressIn={ControlSelection.block}
                 onPressOut={ControlSelection.unblock}
diff --git a/src/styles/styles.js b/src/styles/styles.js
index 71fed0201..23697f51d 100644
--- a/src/styles/styles.js
+++ b/src/styles/styles.js
@@ -709,7 +709,6 @@ const styles = {
     // Actions
     actionAvatar: {
         borderRadius: 20,
-        marginRight: variables.avatarChatSpacing,
     },

bondydaa · 2023-01-19T17:38:00Z

oh hm dang I do not know what we're supposed to do here, going to ask in slack.

bondydaa · 2023-01-20T17:45:56Z

to recap the slack discussion we're just going to have @Pujan92 re-add the fixes into the PR #14247 to get it re-applied.

Georgia has been OOO and since normally we'd get the PR author who "broke" it to fix it let's bypass that this one time to get the fixes back in place and keep moving forward on these tooltip problems.

bondydaa · 2023-01-20T17:46:14Z

slack thread was here for posterity https://expensify.slack.com/archives/C01GTK53T8Q/p1674149953675229

jatinsonijs · 2023-01-20T17:50:24Z

@bondydaa just want to confirm do it will consider as regression report ?

#13940 (comment)

bondydaa · 2023-01-20T17:54:38Z

yeah I think so 👍

bondydaa · 2023-01-23T15:58:08Z

merged #14247 which is taking care of fixing the regression that got added.

trjExpensify · 2023-02-01T01:38:59Z

This hit prod 7 days ago (Wednesday, 1st Feb). Title didn't update, but doing that now to track it better. Is this the correct summary of payments due?

$250 for @gadhiyamanan for the bug report
$250 for @jatinsonijs for the bug report after someone else's PR broke this again
$1,500 for @Pujan92 for the fix + 50% bonus for PR merged within 3 days
$1,500 to @eVoloshchak for the C+ review + 50% bonus for PR merged within 3 days (we aren't counting someone's regression against this PR)

Let me know and I can ship the offers. Thanks!

Puneet-here · 2023-02-01T05:46:51Z

Hi @trjExpensify, I wanted to confirm if I am eligible for compensation since I mentioned a new instance of this issue and proposed a solution which was used. A similar case was here.

Pujan92 · 2023-02-01T15:39:15Z

@Puneet-here Just sharing my similar case here where it has counted as a suggestion. 😅

trjExpensify · 2023-02-01T16:28:02Z

Hey @Puneet-here, can you be more specific/direct with what your implying, please? I don't know what you're pointing to there with @JmillsExpensify's summary of payments on another issue? 😕

The way I see it, this issue was created from a bug reported by @gadhiyamanan in #expensify-bugs as per the OP. We don't compensate for suggestions, and the solution we accepted was @Pujan92's.

Puneet-here · 2023-02-01T17:11:29Z

Sorry for not being specific earlier. I was sharing a similar case where two contributors were compensated because the code that was use in the final PR was from both contributors (me and allrounderexperts)

daraksha-dk mentioned one new instance of this issue and provided a solution, in their case a new issue was created and the issue was assigned to them for solving.

I had also added a new instance of this issue and provided the solution to fix that. The solution was used in the final PR. That's why I wanted to confirm if I am eligible for compensation since it is similar to above cases.

trjExpensify · 2023-02-01T19:23:34Z

Thanks! @daraksha-dk's issue was for the back/header buttons, which was treated separately because it had a different implementation as per the outcome of this thread.

Your proposal on this issue wasn't accepted unfortunately, and the initial report came from @gadhiyamanan, so I don't think we treat it as an additional bug report - like we are the one where @jatinsonijs found a regression from another PR that reverted these changes.

trjExpensify · 2023-02-01T19:34:35Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Pujan92 / @eVoloshchak] The PR that introduced the bug has been identified. Link to the PR: Added tooltips to all Icon buttons #4661
[@Pujan92 / @eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added tooltips to all Icon buttons #4661 (comment)
[@Pujan92 / @eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not sure if this is necessary, this should have been caught during the initial review, it's a visual bug
[@trjExpensify] A regression test has been added or updated so that the same bug will not reach production again. - we aren't adding a regression test to the run for a purely visual bug

Puneet-here · 2023-02-02T05:45:34Z

By new "instance" I meant I reported and provided solution for a new place where this bug was present (it was also present in names, here's my comment ) that instance was not part of the original issue but we decided to fix it here and since pujan had proposed the solution first for the original issue their proposal was taken and we included the fix for the new instance in the same PR so I think my case is similar as darkasha-dk 's, but in my case a new issue wasn't created.

trjExpensify · 2023-02-02T17:14:41Z

Ahh, I see. Thanks for elaborating on that, so yes, I'll ship you a bug reporting bonus.

trjExpensify · 2023-02-03T11:53:59Z

All done here!

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 2, 2023

melvin-bot bot locked and limited conversation to collaborators Jan 2, 2023

melvin-bot bot assigned trjExpensify Jan 2, 2023

trjExpensify added the External Added to denote the issue can be worked on by a contributor label Jan 3, 2023

melvin-bot bot unlocked this conversation Jan 3, 2023

melvin-bot bot changed the title ~~Tooltip is not in the center while hovering on a profile pic~~ [$1000] Tooltip is not in the center while hovering on a profile pic Jan 3, 2023

melvin-bot bot assigned eVoloshchak Jan 3, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 3, 2023

melvin-bot bot assigned bondydaa Jan 3, 2023

bondydaa mentioned this issue Jan 6, 2023

[HOLD for payment 2023-01-19] [$1000] Tooltip is not centered when hovering the < (back icon) on modals #14043

Closed

6 tasks

Pujan92 mentioned this issue Jan 6, 2023

tooltip position fix for profile pic and display name #14053

Merged

53 tasks

melvin-bot bot added the Reviewing Has a PR in review label Jan 6, 2023

Pujan92 mentioned this issue Jan 20, 2023

composer icons tooltip position fix #14247

Merged

53 tasks

bondydaa mentioned this issue Jan 23, 2023

[HOLD for payment 2023-02-01] [$1000] align center the tooltip positions for Action, Expand & Collapse icon in the composer #14231

Closed

1 task

trjExpensify changed the title ~~[$1000] Tooltip is not in the center while hovering on a profile pic~~ [Hold for payment 01-02-2023] [$1000] Tooltip is not in the center while hovering on a profile pic Feb 1, 2023

trjExpensify closed this as completed Feb 3, 2023

Tushu17 mentioned this issue Feb 4, 2023

[$1000] Help tab on settings page should have external link icon like Settings->about->View open jobs and not the current navigation icon #14693

Closed

6 tasks

[Hold for payment 01-02-2023] [$1000] Tooltip is not in the center while hovering on a profile pic #13940

[Hold for payment 01-02-2023] [$1000] Tooltip is not in the center while hovering on a profile pic #13940

Comments

kavimuru commented Jan 2, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

trjExpensify commented Jan 3, 2023

melvin-bot bot commented Jan 3, 2023

melvin-bot bot commented Jan 3, 2023

melvin-bot bot commented Jan 3, 2023

melvin-bot bot commented Jan 3, 2023

Pujan92 commented Jan 3, 2023 • edited Loading

bondydaa commented Jan 3, 2023

bondydaa commented Jan 4, 2023

bondydaa commented Jan 4, 2023

Pujan92 commented Jan 4, 2023

shawnborton commented Jan 4, 2023

shawnborton commented Jan 4, 2023

Pujan92 commented Jan 4, 2023

Puneet-here commented Jan 4, 2023

Proposal

Pujan92 commented Jan 4, 2023

Pujan92 commented Jan 4, 2023

umair-upwork commented Jan 4, 2023 • edited Loading

Proposal

Problem

Solution

Tooltip will always remain centered while hovering on a profile pic or name

Demo

syedsaroshfarrukhdot commented Jan 4, 2023 • edited Loading

daraksha-dk commented Jan 4, 2023

Proposal

There are two main sections where this issue resides:

1. for Header buttons

Changes that needs to be done:

Another way to solve these problems (IMO Better):

2. for Avatar and Name tooltips

Changes

Pujan92 commented Jan 4, 2023

Pujan92 commented Jan 6, 2023

Puneet-here commented Jan 13, 2023

melvin-bot bot commented Jan 13, 2023

eVoloshchak commented Jan 13, 2023 • edited Loading

jatinsonijs commented Jan 19, 2023

Pujan92 commented Jan 19, 2023 • edited Loading

bondydaa commented Jan 19, 2023

bondydaa commented Jan 20, 2023

bondydaa commented Jan 20, 2023

jatinsonijs commented Jan 20, 2023

bondydaa commented Jan 20, 2023

bondydaa commented Jan 23, 2023

trjExpensify commented Feb 1, 2023

Puneet-here commented Feb 1, 2023

Pujan92 commented Feb 1, 2023

trjExpensify commented Feb 1, 2023

Puneet-here commented Feb 1, 2023 • edited Loading

trjExpensify commented Feb 1, 2023

trjExpensify commented Feb 1, 2023 • edited Loading

Puneet-here commented Feb 2, 2023

trjExpensify commented Feb 2, 2023

trjExpensify commented Feb 3, 2023

kavimuru commented Jan 2, 2023 •

edited by melvin-bot bot

Loading

Pujan92 commented Jan 3, 2023 •

edited

Loading

umair-upwork commented Jan 4, 2023 •

edited

Loading

syedsaroshfarrukhdot commented Jan 4, 2023 •

edited

Loading

eVoloshchak commented Jan 13, 2023 •

edited

Loading

Pujan92 commented Jan 19, 2023 •

edited

Loading

Puneet-here commented Feb 1, 2023 •

edited

Loading

trjExpensify commented Feb 1, 2023 •

edited

Loading