-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2022-12-08] Android -Chat - The compose field is covered by keyboard #13111
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @roryabraham ( |
This will be fixed by #13106 |
@luacmartins I don't know if we want to wait for #13106, but looking through the checklist I think the only change that might've caused this is #12988 |
I am not sure if #12988 can cause the regression, as the code only removes one placeholder. No other change. |
After deep research, I finally found that #12642 caused regression. - StatusBar.setTranslucent(true); But I think this is a good solution to fix another related issues so I don't recommend to revert this. #13106 will fix all of the related issues along with this GH. Let me list again the issues this PR will fix: cc: @tgolen @roryabraham @mountiny @pecanoro @iwiznia @Julesssss (since you were assigned one of the related issues or PRs) |
Great investigation and fix @0xmiroslav 🙇 |
Confirmed this is resolved by this PR. |
The solution here is to have the PR reviewed asap to unblock the deploy. |
This is fixed by #13106, closing! |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2022-12-08. 🎊 After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
The message field should be fully visible if the keyboard was open.
Actual Result:
The message field is hidden if the keyboard was open.
Workaround:
unknown
Platform:
Where is this issue occurring?
Version Number: 1.2.33-1

Reproducible in staging?: y
Reproducible in production?: n
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5839913_az_recorder_20221128_165302.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: