Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2022-12-08] Android -Chat - The compose field is covered by keyboard #13111

Closed
kavimuru opened this issue Nov 28, 2022 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Launch app > go to any chat
  2. Start to enter message

Expected Result:

The message field should be fully visible if the keyboard was open.

Actual Result:

The message field is hidden if the keyboard was open.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.2.33-1
Reproducible in staging?: y
Reproducible in production?: n
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5839913_az_recorder_20221128_165302.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Nov 28, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Nov 28, 2022

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@0xmiros
Copy link
Contributor

0xmiros commented Nov 29, 2022

This will be fixed by #13106

@roryabraham
Copy link
Contributor

@luacmartins I don't know if we want to wait for #13106, but looking through the checklist I think the only change that might've caused this is #12988

@mananjadhav
Copy link
Collaborator

I am not sure if #12988 can cause the regression, as the code only removes one placeholder. No other change.

@0xmiros
Copy link
Contributor

0xmiros commented Nov 29, 2022

After deep research, I finally found that #12642 caused regression.
Especially, this change:

-       StatusBar.setTranslucent(true);

But I think this is a good solution to fix another related issues so I don't recommend to revert this.

#13106 will fix all of the related issues along with this GH.

Let me list again the issues this PR will fix:
#10483
#10609
#11087
#12592
#12622
#13111
#13152

cc: @tgolen @roryabraham @mountiny @pecanoro @iwiznia @Julesssss (since you were assigned one of the related issues or PRs)

@mountiny
Copy link
Contributor

Great investigation and fix @0xmiroslav 🙇

@Julesssss
Copy link
Contributor

Confirmed this is resolved by this PR.

@Julesssss
Copy link
Contributor

The solution here is to have the PR reviewed asap to unblock the deploy.

@luacmartins
Copy link
Contributor

This is fixed by #13106, closing!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Dec 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 1, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-12-08. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot changed the title Android -Chat - The compose field is covered by keyboard [HOLD for payment 2022-12-08] Android -Chat - The compose field is covered by keyboard Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants