[Hold for Payment: 2022-12-09] [$2000] Bug: Blank page is shown for archived room with a message reported by @Puneet-here

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Create a workspace if you don't have any
2. Go to members page and remove the other admin ( Expensify setup specialist )
3. Search the announce room and send a message
4. Pin the room and delete the workspace
5. Wait for a few seconds (Reload if the chat is still visible)
6. Verify you are seeing a blank page

Expected Result:

You should see the room

Actual Result:

Blank page is shown

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.18-2
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2022-10-20.at.2.26.36.AM.mov

Recording.748.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666254716913509

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0163a0872c1900089b
• Upwork Job ID: 1595054682309058560

[melvin-bot]

Triggered auto assignment to @dylanexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[mallenexpensify]

@dylanexpensify new BZ chore SO is here, we want to ensure BZ stays assigned to all issues so we can get to BugZero,

[melvin-bot]

@dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[dylanexpensify]

Reviewing today!

[dylanexpensify]

Posted in slack for clarification

[dylanexpensify]

Upwork: https://www.upwork.com/jobs/~01e18b2ee260ebaf80

[melvin-bot]

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Triggered auto assignment to @dangrous (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dylanexpensify]

Not overdue, awaiting proposals

[dangrous]

Preempting Melvin here, still awaiting proposals.

[dylanexpensify]

reviewing today!

[dangrous]

This has been merged and is currently on staging! I'm not sure why the automated message didn't say that. But it has been.

[dangrous]

This was deployed to production on 12/2, so 12/9 is our target for payment! (Adding this info here because the bot got broken before commenting on this)

[dylanexpensify]

@hellohublot @thesahindia can we get you to apply to the upwork job please!

[hellohublot]

@dylanexpensify Yes, I have applied on upwork, my upwork home page is https://www.upwork.com/freelancers/~01509ca2c74bfc7073

[dylanexpensify]

hmmm, i don't see your application - it's for this one, yes? https://www.upwork.com/jobs/~0163a0872c1900089b

[thesahindia]

@dylanexpensify, is this also eligible for the bonus since the PR was approved within 3 days but we were waiting for approval from Carlos?

[hellohublot]

@dylanexpensify Yes, I encountered the same problem last time. My upwork account shows that it has been submitted, but you can't receive it. I really don't know what the problem is.

Maybe you need to help send a offer directly like last time. Thank you.

[dylanexpensify]

Oh interesting! Will send direct @hellohublot

[dylanexpensify]

@thesahindia I see the PR raised Nov 29th, when did we merge it?

[dylanexpensify]

@hellohublot sent an offer direct

[thesahindia]

Dec 1st

[dylanexpensify]

Nice, then yes, this will qualify!

[dylanexpensify]

Alright, all payments sent!

We still have this to do:

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

• @dylanexpensify A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
• @thesahindia @dangrous @cead22 The PR that introduced the bug has been identified. Link to the PR: n/a - not a regression, rather an unnoticed edge case.
• @thesahindia @dangrous @cead22 The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a - not a regression, rather an unnoticed edge case.
• @thesahindia @dangrous @cead22 A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a - not a regression, rather an unnoticed edge case.
• @dylanexpensify Payment has been made to the issue reporter (if applicable)
• @dylanexpensify Payment has been made to the contributor that fixed the issue (if applicable)
• @dylanexpensify Payment has been made to the contributor+ that helped on the issue (if applicable)

[dylanexpensify]

posted regression test buddy check, waiting to hear back

[dangrous]

Re: regression - is this actually a regression, or is it a case that was just previously missed? That is, was this ever working?

[thesahindia]

or is it a case that was just previously missed?

I believe so and since it was an edge case I highly doubt if this could have been prevented.

[dangrous]

Yeah agreed. I think once the new regression test is buddy checked I think we should be good to close out; the PR-related checkboxes here are not relevant as it was not a regression.

[JmillsExpensify]

Anyone know where the regression test lives? I think we shouldn't wait until Dylan returns. Let's get this one closed out. I'm happy to jump in for him.

[mallenexpensify]

I should be able to dig in next week to see what's going on, assigned myself

[melvin-bot]

@robertjchen, @dangrous, @hellohublot, @mallenexpensify, @dylanexpensify, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

[thesahindia]

Un-assigned myself since no actions are needed from me.

[mallenexpensify]

Regression test steps discussion is here https://expensify.slack.com/archives/C01SKUP7QR0/p1671114011698279
@dylanexpensify when you're back can you comment here/there?

[dylanexpensify]

Hi all! Back today, reviewing now!

[dylanexpensify]

Commented in thread, creating QA test GH now

[dylanexpensify]

Regression test update GH created here, closing this out!