Skip to content

Commit

Permalink
Merge pull request #5545 from Expensify/joe-remove-vba-password
Browse files Browse the repository at this point in the history
Remove password requirement for setting up withdrawal account
  • Loading branch information
Jag96 authored Sep 30, 2021
2 parents d7efb22 + 6417bb5 commit f189aad
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 23 deletions.
1 change: 0 additions & 1 deletion src/languages/en.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export default {
isRequiredField: 'is a required field',
whatThis: 'What\'s this?',
iAcceptThe: 'I accept the ',
passwordCannotBeBlank: 'Password cannot be blank',
remove: 'Remove',
admin: 'Admin',
dateFormat: 'YYYY-MM-DD',
Expand Down
1 change: 0 additions & 1 deletion src/languages/es.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export default {
isRequiredField: 'es un campo obligatorio',
whatThis: '¿Qué es esto?',
iAcceptThe: 'Acepto los ',
passwordCannotBeBlank: 'La contraseña no puede estar vacía',
remove: 'Eliminar',
admin: 'Administrador',
dateFormat: 'AAAA-MM-DD',
Expand Down
2 changes: 1 addition & 1 deletion src/libs/API.js
Original file line number Diff line number Diff line change
Expand Up @@ -968,7 +968,7 @@ function BankAccount_SetupWithdrawal(parameters) {

requireParameters(['currentStep'], parameters, commandName);
return Network.post(
commandName, {additionalData: JSON.stringify(additionalData), password: parameters.password},
commandName, {additionalData: JSON.stringify(additionalData)},
CONST.NETWORK.METHOD.POST,
true,
);
Expand Down
20 changes: 0 additions & 20 deletions src/pages/ReimbursementAccount/CompanyStep.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ class CompanyStep extends React.Component {
incorporationDate: ReimbursementAccountUtils.getDefaultStateForField(props, 'incorporationDate'),
incorporationState: ReimbursementAccountUtils.getDefaultStateForField(props, 'incorporationState'),
hasNoConnectionToCannabis: ReimbursementAccountUtils.getDefaultStateForField(props, 'hasNoConnectionToCannabis', false),
password: '',
};

// These fields need to be filled out in order to submit the form
Expand All @@ -79,7 +78,6 @@ class CompanyStep extends React.Component {
'incorporationDate',
'incorporationState',
'incorporationType',
'password',
'companyPhone',
'hasNoConnectionToCannabis',
];
Expand All @@ -95,7 +93,6 @@ class CompanyStep extends React.Component {
companyTaxID: 'bankAccount.error.taxID',
incorporationDate: 'bankAccount.error.incorporationDate',
incorporationType: 'bankAccount.error.companyType',
password: 'common.passwordCannotBeBlank',
hasNoConnectionToCannabis: 'bankAccount.error.restrictedBusiness',
};

Expand Down Expand Up @@ -281,23 +278,6 @@ class CompanyStep extends React.Component {
/>
</View>
</View>
<ExpensiTextInput
label={`Expensify ${this.props.translate('common.password')}`}
containerStyles={[styles.mt4]}
secureTextEntry
textContentType="password"
onChangeText={(value) => {
this.setState({password: value});
this.clearError('password');
}}
value={this.state.password}
onSubmitEditing={this.submit}
errorText={this.getErrorText('password')}

// Use new-password to prevent an autoComplete bug https://github.com/Expensify/Expensify/issues/173177
// eslint-disable-next-line react/jsx-props-no-multi-spaces
autoCompleteType="new-password"
/>
<CheckboxWithLabel
isChecked={this.state.hasNoConnectionToCannabis}
onPress={() => {
Expand Down

0 comments on commit f189aad

Please sign in to comment.