Skip to content

Commit

Permalink
Merge pull request #21655 from fedirjh/Fix-Dev-Beta-Access
Browse files Browse the repository at this point in the history
[No QA] [Fix] Remove all Betas access for dev environment
  • Loading branch information
flodnv authored Jul 3, 2023
2 parents 8b7a65d + 6a5fffc commit d7cf0bc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
9 changes: 4 additions & 5 deletions src/libs/Permissions.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import _ from 'underscore';
import * as Environment from './Environment/Environment';
import CONST from '../CONST';

/**
Expand All @@ -8,7 +7,7 @@ import CONST from '../CONST';
* @returns {Boolean}
*/
function canUseAllBetas(betas) {
return Environment.isDevelopment() || _.contains(betas, CONST.BETAS.ALL);
return _.contains(betas, CONST.BETAS.ALL);
}

/**
Expand Down Expand Up @@ -75,7 +74,7 @@ function canUseCommentLinking(betas) {
* @returns {Boolean}
*/
function canUsePolicyRooms(betas) {
return _.contains(betas, CONST.BETAS.POLICY_ROOMS) || _.contains(betas, CONST.BETAS.ALL);
return _.contains(betas, CONST.BETAS.POLICY_ROOMS) || canUseAllBetas(betas);
}

/**
Expand All @@ -91,15 +90,15 @@ function canUsePolicyExpenseChat(betas) {
* @returns {Boolean}
*/
function canUsePasswordlessLogins(betas) {
return _.contains(betas, CONST.BETAS.PASSWORDLESS) || _.contains(betas, CONST.BETAS.ALL);
return _.contains(betas, CONST.BETAS.PASSWORDLESS) || canUseAllBetas(betas);
}

/**
* @param {Array<String>} betas
* @returns {Boolean}
*/
function canUseTasks(betas) {
return _.contains(betas, CONST.BETAS.TASKS) || _.contains(betas, CONST.BETAS.ALL);
return _.contains(betas, CONST.BETAS.TASKS) || canUseAllBetas(betas);
}

export default {
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/OptionsListUtilsTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ describe('OptionsListUtils', () => {

it('getSearchOptions()', () => {
// When we filter in the Search view without providing a searchValue
let results = OptionsListUtils.getSearchOptions(REPORTS, PERSONAL_DETAILS, '');
let results = OptionsListUtils.getSearchOptions(REPORTS, PERSONAL_DETAILS, '', [CONST.BETAS.ALL]);

// Then the 2 personalDetails that don't have reports should be returned
expect(results.personalDetails.length).toBe(2);
Expand Down

0 comments on commit d7cf0bc

Please sign in to comment.