Use local variable isChatRoom instead of referencing twice

Expensify · Feb 1, 2022 · 88250fb · 88250fb
1 parent 5e7299c
commit 88250fb
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/libs/actions/Report.js b/src/libs/actions/Report.js
@@ -330,9 +330,15 @@ function configureReportNameAndIcons(reports, details) {
         if (report.participants.length <= 0 && !ReportUtils.isChatRoom(report)) {
             return;
         }
+        const isChatRoom = ReportUtils.isChatRoom(report);
 
-        const avatars = ReportUtils.isChatRoom(report) ? (['']) : OptionsListUtils.getReportIcons(report, details);
-        const reportName = ReportUtils.isChatRoom(report)
+        // Chat rooms have a specific avatar so we can return any non-empty array but for 1:1 chats and group chats
+        // avatars are extracted from avatars of the participants.
+        const avatars = isChatRoom ? (['']) : OptionsListUtils.getReportIcons(report, details);
+
+        // ReportName is already present in report for chatrooms but for 1:1 chats and group chats
+        // reportName is extracted from displayNames of the participants.
+        const reportName = isChatRoom
             ? report.reportName
             : _.chain(report.participants)
                 .filter(participant => participant !== currentUserEmail)