Merge branch 'yuwen-nsqs' of github.com:Expensify/App into yuwen-nsqs

Expensify · Feb 10, 2025 · 6fd0bed · 6fd0bed
2 parents fc80bc5 + 5a4294c
commit 6fd0bed
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/libs/PolicyUtils.ts b/src/libs/PolicyUtils.ts
@@ -997,8 +997,8 @@ function getIntegrationLastSuccessfulDate(connection?: Connections[keyof Connect
     return syncSuccessfulDate;
 }
 
-function getNSQSCompanyID(policy: Policy | undefined) {
-    return policy?.connections?.netsuiteQuickStart?.config?.credentials?.companyID;
+function getNSQSCompanyID(policy: Policy) {
+    return policy.connections?.netsuiteQuickStart?.config?.credentials?.companyID;
 }
 
 function getCurrentSageIntacctEntityName(policy: Policy | undefined, defaultNameIfNoEntity: string): string | undefined {

diff --git a/src/libs/actions/connections/index.ts b/src/libs/actions/connections/index.ts
@@ -258,7 +258,7 @@ function syncConnection(policy: Policy | undefined, connectionName: PolicyConnec
         },
     ];
 
-    let parameters: SyncPolicyToQuickbooksDesktopParams | SyncPolicyToNSQSParams = {
+    const parameters: SyncPolicyToQuickbooksDesktopParams | SyncPolicyToNSQSParams = {
         policyID,
         idempotencyKey: policyID,
     };
@@ -267,10 +267,7 @@ function syncConnection(policy: Policy | undefined, connectionName: PolicyConnec
         parameters.forceDataRefresh = forceDataRefresh;
     }
     if (connectionName === CONST.POLICY.CONNECTIONS.NAME.NSQS) {
-        parameters = {
-            ...parameters,
-            netSuiteAccountID: getNSQSCompanyID(policy),
-        } as SyncPolicyToNSQSParams;
+        (parameters as SyncPolicyToNSQSParams).netSuiteAccountID = getNSQSCompanyID(policy) as string;
     }
 
     API.read(syncConnectionData.readCommand, parameters, {