Perf: improve performance of filterAndOrderOptions

Expensify · Jan 30, 2025 · 54071b4 · 54071b4
1 parent a32c86b
commit 54071b4
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/libs/OptionsListUtils.ts b/src/libs/OptionsListUtils.ts
@@ -2050,7 +2050,15 @@ function filterAndOrderOptions(options: Options, searchInputValue: string, confi
     const orderedOptions = combineOrderingOfReportsAndPersonalDetails(filterResult, searchInputValue, config);
 
     // on staging server, in specific cases (see issue) BE returns duplicated personalDetails entries
-    orderedOptions.personalDetails = orderedOptions.personalDetails.filter((detail, index, array) => array.findIndex((i) => i.login === detail.login) === index);
+    const uniqueLogins = new Set<string>();
+    orderedOptions.personalDetails = orderedOptions.personalDetails.filter((detail) => {
+        const login = detail.login ?? '';
+        if (uniqueLogins.has(login)) {
+            return false;
+        }
+        uniqueLogins.add(login);
+        return true;
+    });
 
     return {
         ...filterResult,