Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: jsdom import #15

Merged
merged 2 commits into from
Oct 24, 2024
Merged

fix: jsdom import #15

merged 2 commits into from
Oct 24, 2024

Conversation

sparten11740
Copy link
Contributor

Fixes a regression from #12 that resulted in failing to import the jsdom environment.

@sparten11740 sparten11740 self-assigned this Oct 16, 2024
@sparten11740 sparten11740 requested a review from ChALkeR as a code owner October 16, 2024 12:32
@sparten11740
Copy link
Contributor Author

sparten11740 commented Oct 16, 2024 •
edited
Loading

unshare: write failed /proc/self/uid_map: Operation not permitted

odd issue in the CI, pnpm test:all passes locally 🤔 (the CI fails on master as well after re-running)

@sparten11740 sparten11740 force-pushed the sparten11740/fix/jsdom-import branch 2 times, most recently from 6649592 to d19fcec Compare October 16, 2024 13:09
mvayngrib
mvayngrib approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@mvayngrib mvayngrib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ChALkeR ChALkeR force-pushed the sparten11740/fix/jsdom-import branch from d19fcec to 04cfb87 Compare October 24, 2024 18:57
@ChALkeR ChALkeR merged commit 0f09c08 into main Oct 24, 2024
9 checks passed
ChALkeR pushed a commit that referenced this pull request Oct 24, 2024
@sparten11740 @ChALkeR
fix: jsdom import (#15)
3712af4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvayngrib mvayngrib mvayngrib approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

@633kh4ck 633kh4ck Awaiting requested review from 633kh4ck

Assignees

@sparten11740 sparten11740

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sparten11740 @mvayngrib @ChALkeR