feat: add signBuffer function #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feri42
requested review from
kewde,
diegomura,
mvayngrib and
sparten11740
as code owners
|
Concept ACK |
mvayngrib
approved these changes
Jan 2, 2025
|
Added some tests. Good to go? |
feri42
force-pushed
the
f/add-sign-buffer-function
branch
from
0230a9e to
0596612
Compare
|
@sparten11740 , @diegomura good to go? |
feri42
added a commit
that referenced
this pull request
Jan 13, 2025
feri42
added a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the signing function from tx-signer, so that we don't need that much keychain detail knowledge in tx-signer.
Looking for Conept ACK (initially).