Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Fix include_directories for exiv2lib target (0.27->master) #1294

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 10, 2020

One more fixup we discovered in Nixpkgs (NixOS/nixpkgs#97161 (comment)).

The headers are installed to ${CMAKE_INSTALL_INCLUDEDIR} but the CMake config was hardcoded to include directory.

The headers are installed to ${CMAKE_INSTALL_INCLUDEDIR} but the CMake config was hardcoded to include directory.
@clanmills clanmills requested a review from piponazo September 10, 2020 21:18
@clanmills clanmills self-assigned this Sep 10, 2020
@clanmills clanmills added this to the v0.27.4 milestone Sep 10, 2020
@clanmills
Copy link
Collaborator

Thanks, Jan. This looks like another great find. Remember my question: "What else lives at the bottom of the swamp?". I'll deal with this tomorrow. Thank You for taking the time to let me know about this.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks! 👍

@piponazo
Copy link
Collaborator

@clanmills I'll let you merge this PR one you think it is appropriate. These days I have been taking care of merging things in master, but I am not so active in seeing the progress on 0.27-maintenance.

@clanmills
Copy link
Collaborator

Don't think about 0.27-maintenance. I'll take care of it!

Thanks very much for your efforts in the last couple of days. I really appreciate you and @neheb working together.

It's good to see the CI working properly on master. I'm about to try to fix it on 0.27-maintenance. I'd really like both 0.27-maintenance and master to build Cygwin64 and MinGW/msys2. If you know how to do that, I'd appreciate your help.

@clanmills clanmills changed the title cmake: Fix include_directories for exiv2lib target cmake: Fix include_directories for exiv2lib target (0.27->master) Sep 11, 2020
@clanmills clanmills merged commit e2500bc into Exiv2:0.27-maintenance Sep 15, 2020
@jtojnar jtojnar deleted the includedir branch September 16, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants