Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow deep import of any package #19

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

Toxicable
Copy link
Contributor

Allowos for correct npm label generation for deep imports of any package, not just @angular/material and @angular/cdk

package.json Outdated Show resolved Hide resolved
src/generators/ts/ts.generator.ts Outdated Show resolved Hide resolved
@mattem
Copy link
Contributor

mattem commented Feb 3, 2020

Thanks for the PR!
Regarding the .vscode dir, is that normally something that's committed? It's not something I'm overly familiar with.

@Toxicable
Copy link
Contributor Author

@mattem Ah yeah, as usual, it depends.
We commit it at work since it has that funky config to fix up source maps, ill leave it out of this PR for now though since there's no isntructions on how to use it

@Toxicable Toxicable force-pushed the deep-import branch 2 times, most recently from a7d8653 to 9203c93 Compare February 3, 2020 18:04
package.json Outdated Show resolved Hide resolved
src/generators/ts/ts.generator.ts Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@mattem
Copy link
Contributor

mattem commented Feb 4, 2020

I'm not sure why the GH actions aren't running, I'll dig into that, don't think there is anything special that we have to do for forks.

mattem
mattem previously approved these changes Feb 4, 2020
@mattem
Copy link
Contributor

mattem commented Feb 4, 2020

Should have fixed the build action, can you rebase against master?

@Toxicable
Copy link
Contributor Author

Ah awesome, will do this afternoon when I get home

@Toxicable
Copy link
Contributor Author

@mattem fixed!

@mattem
Copy link
Contributor

mattem commented Feb 6, 2020

Looks good, thanks!

@mattem mattem merged commit b95c8d7 into Evertz:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants