New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed possible null exception in ImGuiManager #3

Merged

jcant0n merged 1 commit into EvergineTeam:main from NinovanderMark:null-reference-fix

Jun 18, 2024

Contributor

NinovanderMark commented Aug 18, 2023

I ran into this exception after adding ImGUI version 2023.3.1.2 to an Evergine project, it happens when closing the application.

My assumption is that the camera is disposed before the ImGuiManager, making the ActiveCamera3D property return null.

Please let me know if any changes are required before this can be merged.


          Fixed possible null exception in ImGuiManager

e417d68

jcant0n approved these changes

View reviewed changes

Member

jcant0n left a comment

Thank you for your feedback and code.

jcant0n merged commit 499377c into EvergineTeam:main

NinovanderMark deleted the null-reference-fix branch

June 21, 2024 05:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet