Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replaced linting tool with a stricter one and fixed i18n issue in Node v22.12.0 #61

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

TNXG
Copy link
Collaborator

@TNXG TNXG commented Jan 6, 2025

  • 通过绕过astro-i18next库使用其上游库i18next尝试解决了在Node v22.12.0版本出现的i18n不工作问题

  • 通过与 SunMaple 的交谈确定将代码格式化程序更换为ESLint

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frosti ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 4:07pm

Copy link

sonarqubecloud bot commented Jan 6, 2025

@TNXG
Copy link
Collaborator Author

TNXG commented Jan 6, 2025

about #57

@EveSunMaple EveSunMaple self-assigned this Jan 6, 2025
@EveSunMaple EveSunMaple self-requested a review January 6, 2025 16:10
@TNXG TNXG self-assigned this Jan 6, 2025
Copy link
Owner

@EveSunMaple EveSunMaple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,我已经审查完毕,绝大部分是格式化,非常感谢您的工作!

我会继续关注 astro-i18next 的进程


const { USER_SITE } = await import('./src/consts.ts');
const { USER_SITE } = await import("./src/consts.ts");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里我会改成同 import { CODE_THEME } from "./src/consts.ts"; 一样的方式

@EveSunMaple EveSunMaple merged commit 7ed5c5f into main Jan 6, 2025
4 checks passed
@EveSunMaple EveSunMaple mentioned this pull request Jan 6, 2025
@TNXG TNXG deleted the tnxg-fix branch January 6, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants