Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic row filtering #362

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Basic row filtering #362

wants to merge 34 commits into from

Conversation

tmichela
Copy link
Member

Implements basic row filtering based on column values, there are more requirements for this feature, bu that's already a big enough diff and does already something useful.

One regression: support for standalone comments is dropped in the main table. I implemented another table to view them for the proposal that have used them.

damnit-row-filtering.webm

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 80.42105% with 93 lines in your changes missing coverage. Please review.

Project coverage is 75.43%. Comparing base (a0b022f) to head (a26e60e).

Files with missing lines Patch % Lines
damnit/gui/table_filter.py 78.17% 67 Missing ⚠️
damnit/gui/table.py 60.00% 16 Missing ⚠️
damnit/gui/standalone_comments.py 89.15% 9 Missing ⚠️
damnit/gui/plot.py 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
- Coverage   75.99%   75.43%   -0.56%     
==========================================
  Files          33       35       +2     
  Lines        5473     5825     +352     
==========================================
+ Hits         4159     4394     +235     
- Misses       1314     1431     +117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmichela tmichela added enhancement New feature or request GUI For GUI-related things labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI For GUI-related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant