Fixed the issue where Windows Vibrancy was not working on newer versions of macOS due to the outdated macos-release package. #9896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In current latest version, window vibrancy option in macOS is broken, as mentioned in issue #9389
After some investigation, I've found the root cause: the version of the macos-release package being used is 3.1.0, which does not support macOS 14.
As a result, on macOS 14, the
macOSRelease().version
inapp/lib/windows.ts
always returns an empty string, causing the macOSVibrancyType variable to always default to'dark'
(which has been deprecated in newer versions of macOS) instead of the intended'under-window'
.This ultimately leads to the failure of the
Settings/Window/Vibrancy
option (the background remains totally opaque).Updating the macos-release package to the latest version will return the correct system version and resolve this issue.
The attachment shows a comparison before and after the modifications. The NSVisualEffectView used by Electron has relatively high opacity, making the effect less noticeable, but upon close inspection, the difference can be seen.
There seems to be another issue: the
Vibrancy
andOpaque
options seem to conflict with each other on macOS 14.The
Vibrancy
option only takes effect when theOpaque
option is set to full.