Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue where Windows Vibrancy was not working on newer versions of macOS due to the outdated macos-release package. #9896

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

fireblue
Copy link
Contributor

Hi,

In current latest version, window vibrancy option in macOS is broken, as mentioned in issue #9389

After some investigation, I've found the root cause: the version of the macos-release package being used is 3.1.0, which does not support macOS 14.

As a result, on macOS 14, the macOSRelease().version in app/lib/windows.ts always returns an empty string, causing the macOSVibrancyType variable to always default to 'dark' (which has been deprecated in newer versions of macOS) instead of the intended 'under-window'.

This ultimately leads to the failure of the Settings/Window/Vibrancy option (the background remains totally opaque).

Updating the macos-release package to the latest version will return the correct system version and resolve this issue.

The attachment shows a comparison before and after the modifications. The NSVisualEffectView used by Electron has relatively high opacity, making the effect less noticeable, but upon close inspection, the difference can be seen.

There seems to be another issue: the Vibrancy and Opaque options seem to conflict with each other on macOS 14.

The Vibrancy option only takes effect when the Opaque option is set to full.

截屏2024-08-22 22 20 45 截屏2024-08-22 22 20 20

…ons of macOS due to the outdated macos-release package.
@Eugeny
Copy link
Owner

Eugeny commented Aug 22, 2024

Thank you!

@Eugeny Eugeny merged commit ccee879 into Eugeny:master Aug 22, 2024
10 checks passed
@Eugeny
Copy link
Owner

Eugeny commented Aug 22, 2024

@all-contributors please add @fireblue for code

Copy link
Contributor

@Eugeny

I've put up a pull request to add @fireblue! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants