Fix Bad Sampling Periods in Hyperparameter Tuner #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Abdu-Hekal I also cherry-picked the corrections from #45 to address #53. Please check that it works :) |
|
Passed CI/CD |
|
@EthanJamesLew Merged and validated against systems with inputs and without. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #52 , the hyperparameter tuner will use bad sampling periods when tuning against a re-sampled model. This patch corrects this. However, this is a result of counterintuitive interface design, and should likely be addressed by tweaking the class interfaces.
CC @Abdu-Hekal feel free to cherry-pick or merge. I ran it against your script for validation.