Fix remaining offline visibility checks #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purpur added a new self-referencing method that we don't implement with our stub class. This will prevent Player#canSee from being called for offline players (it would be false anyway).
JRoy
added
type: bugfix
mdcfe
approved these changes
Aug 5, 2023
Starmism
pushed a commit
to valence-smp/Essentials
that referenced
this pull request
Jan 8, 2025
Purpur added a new self-referencing method that we don't implement with our stub class. This will prevent Player#canSee from being called for offline players (it would be false anyway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpur added a new self-referencing method that
we don't implement with our stub class. This will
prevent Player#canSee from being called for offline players (it would be false anyway).
Mitigates #5318 and #5465
Continuation of a1fa1e3