Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack overflow when disabling commands from other addons #4680

Merged

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Dec 12, 2021

caused by not actually disabling the alt command handler for addons (using getPlugin == this instead of getPlugin#getDescription#getMain#contains com.earth2me

Fixes #4678

@JRoy JRoy added the module: main Issues or PRs for the main Essentials module label Dec 12, 2021
@JRoy JRoy added this to the 2.19.1 milestone Dec 12, 2021
@pop4959 pop4959 merged commit dae5194 into EssentialsX:2.x Dec 12, 2021
@JRoy JRoy deleted the fix/stackoverflow-disabled-commands-modules branch December 12, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: main Issues or PRs for the main Essentials module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/toggleshout crashes server when it's disabled under disabled-commands
2 participants