Update to 1.18 #4640
Merged
Update to 1.18 #4640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
added
type: enhancement
|
Use rebase when merging this |
mdcfe
requested changes
Nov 26, 2021
Essentials/src/main/java/com/earth2me/essentials/utils/VersionUtil.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Co-authored-by: pop4959 <[email protected]> Co-authored-by: Josh Roy <[email protected]>
JRoy
force-pushed
the
mc/1.18
branch
2 times, most recently
from
cbc742b to
d01419f
Compare
Co-authored-by: Jason <[email protected]>
mdcfe
previously approved these changes
Nov 30, 2021
mdcfe
approved these changes
Nov 30, 2021
mdcfe
requested changes
Nov 30, 2021
Essentials/src/main/java/com/earth2me/essentials/utils/VersionUtil.java
Outdated
Show resolved
Hide resolved
mdcfe
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It compiles, it runs. There is probably a lot of location related y-level bugs that I wasn't able to find issues but I also only tested for 10 minutes. @jpenilla said he may do something for mappings stuff
Do not merge until 1.18 is fully released