-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix daylight shift test #144
Conversation
Would it be simpler to choose a time near noon instead of a time near midnight? |
The problem was daily light shifting. It would've been easier to select another random epoch number but we'll still have some problems with respect to other timezones. So, I forced the return date to be converted and formatted to a timezone that has daylight savings and that should work with any epoch number given. |
So in other words, no what epoch-number we choose, it will be too close to midnight in some time zone. |
import java.text.SimpleDateFormat; | ||
import java.util.ArrayList; | ||
import java.util.Properties; | ||
import java.util.TimeZone; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance of undoing the spurious re-ordering?
Saif - I reviewed TestGeoJsonSerDe looking if it would likely need the same change. It looks like the timezone was addressed in a different manner in that one. Do you think either way is any better or worse than the other? |
I will take a look at it |
I think the approach in TestGeoJsonSerDe should work out fine. I think since it deals with a default timezone offset it will guarantee a more stable time conversion. |
OK, sounds good. |
Well, if it works, we can merge now and later think about consistency of timezone handling in that test for EsriJson & GeoJson. |
This PR contains a simple fix for the failing test in this issue #141