updated sample code and issue template #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasilgeo
reviewed
Aug 11, 2021
jwasilgeo
approved these changes
Aug 11, 2021
Co-authored-by: Jacob Wasilkowski <[email protected]>
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
* updated sample code and issue template * clarify link * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: Jacob Wasilkowski <[email protected]> Co-authored-by: Jacob Wasilkowski <[email protected]>
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
* updated sample code and issue template * clarify link * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: Jacob Wasilkowski <[email protected]> Co-authored-by: Jacob Wasilkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample code in the README was using a service that does not exist anymore. I found a similar service (national parks) that seems to be well maintained (https://www.arcgis.com/home/item.html?id=8b98df1300b749eabc3142864bb9a119) and switched to that. This code is what is in the JSBin link in our Issue Template, so I also created a new JSBin template and linked to that from the issue template.