Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(combobox-item): add defaults and reflects tests #9805

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

jcfranco
Copy link
Member

Related Issue: N/A

Summary

✨🧪✨

@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Jul 17, 2024
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit 1ca5e96 into dev Jul 17, 2024
9 checks passed
@jcfranco jcfranco deleted the jcfranco/improve-combobox-item-test-coverage branch July 17, 2024 20:36
@github-actions github-actions bot added this to the 2024-07-30 - Jul Release milestone Jul 17, 2024
benelan added a commit that referenced this pull request Jul 18, 2024
* origin/dev:
  refactor(dropdown-item): remove unused members (#9794)
  test(combobox-item): add defaults and reflects tests (#9805)
  build(deps): update dependency globby to v14.0.2 (#9802)
  build(deps): update dependency postcss to v8.4.39 (#9803)
  build(deps): update dependency chromatic to v11.5.5 (#9800)
  build(deps): update dependency eslint-plugin-react to v7.34.4 (#9801)
  chore: remove codeowner team to reduce notifications (#9711)
  chore: release next
  fix(radio-button-group): remove blank clickable space outside of label (#9793)
benelan added a commit that referenced this pull request Jul 19, 2024
…-to-monorepo

* origin/dev: (44 commits)
  build: update browserslist db (#9717)
  docs: update component READMEs (#9808)
  build(deps): update dependency rimraf to v5.0.9 (#9810)
  build(deps): update dependency prettier to v3.3.3 (#9809)
  build(deps): fix lerna install errors on osx machines (#9798)
  refactor(dropdown-item): remove unused members (#9794)
  test(combobox-item): add defaults and reflects tests (#9805)
  build(deps): update dependency globby to v14.0.2 (#9802)
  build(deps): update dependency postcss to v8.4.39 (#9803)
  build(deps): update dependency chromatic to v11.5.5 (#9800)
  build(deps): update dependency eslint-plugin-react to v7.34.4 (#9801)
  chore: remove codeowner team to reduce notifications (#9711)
  chore: release next
  fix(radio-button-group): remove blank clickable space outside of label (#9793)
  build: fix globby errors (#9797)
  chore: release next
  fix(deps): move @types/sortablejs as a dependency so the public types resolve properly (#9786)
  refactor(loader): simplify loader part rendering (#9728)
  chore: release next
  feat(combobox, combobox-item): add `description`, `shortHeading` props and `content-end` slot (#9771)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants