Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tile): add content-top and content-bottom slots, deprecate content-start and content-end slots #8984

Merged
merged 9 commits into from
Mar 26, 2024
Merged

feat(tile): add content-top and content-bottom slots, deprecate content-start and content-end slots #8984

merged 9 commits into from
Mar 26, 2024

Conversation

eriklharper
Copy link
Contributor

@eriklharper eriklharper commented Mar 22, 2024 •
edited
Loading

Related Issue: #3462

Summary

This PR adds 2 new slots content-top and content-bottom to replace the now deprecated content-start and content-end slots.

@eriklharper eriklharper requested a review from a team as a code owner March 22, 2024 00:19
@eriklharper eriklharper self-assigned this Mar 22, 2024
@eriklharper eriklharper added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. label Mar 22, 2024
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Mar 22, 2024
@eriklharper eriklharper added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Mar 22, 2024
@eriklharper eriklharper requested a review from jcfranco March 22, 2024 00:19
@eriklharper
replacing content-start slot with image slot in stories
267ab9b
@eriklharper
whew! Renaming image slot to content-top, adding content-bottom slot,…
8923f54 
… moving content-top to above icon prop, restoring deprecated content-start and content-end slots
@eriklharper eriklharper changed the title feat(tile): add image slot, move content-end slot and deprecate content-start slot feat(tile): add content-top and content-bottom slots, deprecate content-start and content-end slots Mar 26, 2024
@eriklharper eriklharper added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. labels Mar 26, 2024
jcfranco
jcfranco approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘
🤘🎸🎸🎸🎸🤘🎸🤘🤘🤘🤘🤘🎸🤘🎸🎸🎸🎸🤘🤘🎸🎸🎸🤘🤘🎸🎸🤘🤘🎸🤘🤘🤘🎸🤘🎸🎸🎸🎸🤘🎸🤘
🤘🎸🤘🤘🎸🤘🎸🤘🤘🤘🤘🤘🎸🤘🎸🤘🤘🤘🤘🎸🤘🤘🤘🤘🎸🤘🤘🎸🤘🎸🎸🤘🎸🎸🤘🎸🤘🤘🤘🤘🎸🤘
🤘🎸🎸🎸🎸🤘🎸🤘🤘🎸🤘🤘🎸🤘🎸🎸🎸🤘🤘🤘🎸🎸🤘🤘🎸🤘🤘🎸🤘🎸🤘🎸🤘🎸🤘🎸🎸🎸🤘🤘🎸🤘
🤘🎸🤘🤘🎸🤘🎸🤘🎸🤘🎸🤘🎸🤘🎸🤘🤘🤘🤘🤘🤘🤘🎸🤘🎸🤘🤘🎸🤘🎸🤘🤘🤘🎸🤘🎸🤘🤘🤘🤘🤘🤘
🤘🎸🤘🤘🎸🤘🤘🎸🤘🤘🤘🎸🤘🤘🎸🎸🎸🎸🤘🎸🎸🎸🤘🤘🤘🎸🎸🤘🤘🎸🤘🤘🤘🎸🤘🎸🎸🎸🎸🤘🎸🤘
🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘

@ashetland @SkyeSeitz Could you help review the screenshot diffs? 🙇

@eriklharper eriklharper added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Mar 26, 2024
@eriklharper eriklharper merged commit eb000d8 into main Mar 26, 2024
16 checks passed
@eriklharper eriklharper deleted the eriklharper/3462-add-image-slot-deprecate-content-start-slot branch March 26, 2024 22:55
@github-actions github-actions bot added this to the 2024-03-26 - Mar Release milestone Mar 26, 2024
@calcite-admin calcite-admin mentioned this pull request Mar 26, 2024
Merged
geospatialem pushed a commit that referenced this pull request Mar 27, 2024
@calcite-admin @github-actions
chore: release main (#8842)
2326ada 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-design-tokens: 2.1.2</summary>

##
[2.1.2](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-03-26)


### Bug Fixes

* Fix invalid font stacks
([#8964](#8964))
([d55186a](d55186a))
</details>

<details><summary>@esri/calcite-components: 2.7.0</summary>

##
[2.7.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-03-26)


### Features

* **button:** Add download property
([#8882](#8882))
([fc55dde](fc55dde))
* **color-picker:** Add `clearable` prop and deprecate `allowEmpty`
([#8910](#8910))
([f036ac2](f036ac2))
* **table-row:** Add alignment property
([#8961](#8961))
([1f81fd7](1f81fd7))
* **tabs:** Make component responsive
([#8616](#8616))
([83a2ef4](83a2ef4))
* **tile:** Add content-top and content-bottom slots, deprecate
content-start and content-end slots
([#8984](#8984))
([eb000d8](eb000d8))


### Bug Fixes

* **action-menu, combobox, dropdown, popover, tooltip:** Use click
instead of pointerdown for click contexts
([#8943](#8943))
([cd7eed9](cd7eed9))
* **card:** Do not apply text color to slotted footer items
([#8839](#8839))
([30a2068](30a2068))
* **combobox:** Prevent spacebar from opening the menu when focused on
chip's close button
([#8990](#8990))
([1a20d0e](1a20d0e))
* **dropdown:** Correct positioning behavior when inside a scrollable
container
([#8973](#8973))
([2524391](2524391))
* **input-time-picker:** Update toggle icon color
([#8955](#8955))
([ce3ac5c](ce3ac5c))
* **input, input-number, input-text:** Ensure values are initialized
properly for dist and components output targets
([#8997](#8997))
([9152211](9152211))
* **list, list-item:** Calcite-select becomes unresponsive in a
list-item if drag-disabled is true
([#8957](#8957))
([e408c62](e408c62))
* **list:** Fix filter box when scrolling in Safari
([#8938](#8938))
([ea8ea1e](ea8ea1e))
* **popover:** Prevent disabled reference elements from toggling popover
([#8983](#8983))
([9f4b14b](9f4b14b))
* **stepper:** Fix layout when switching modes dynamically to
`horizontal-single`
([#8946](#8946))
([01f58bf](01f58bf))
* **table:** Prevent duplicate scrollbars in certain browsers
([#8962](#8962))
([8434eeb](8434eeb))
* **tab:** Style focus outline of tab content
([#8804](#8804))
([8f0133f](8f0133f))


### Performance Improvements

* Update `transition-default` Tailwind util to only target common,
animatable properties
([#8797](#8797))
([f4d016b](f4d016b))


### Reverts

* Refactor(popover): update token pattern
([#8889](#8889))
([c43c280](c43c280))


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @esri/calcite-design-tokens bumped from ^2.1.2-next.2 to ^2.1.2
</details>

<details><summary>@esri/calcite-components-angular: 2.7.0</summary>

##
[2.7.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-03-26)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.7.0-next.17 to ^2.7.0
</details>

<details><summary>@esri/calcite-components-react: 2.7.0</summary>

##
[2.7.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-03-26)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.7.0-next.17 to ^2.7.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eriklharper added a commit that referenced this pull request Mar 28, 2024
@eriklharper
feat(tile): integrate content-top and content-bottom slots per #8984
29f6366
@eriklharper eriklharper mentioned this pull request Mar 28, 2024
Merged
jcfranco pushed a commit that referenced this pull request Mar 29, 2024
@eriklharper
chore(tile): integrate content-top and content-bottom slot changes per …
51585dc 
…#8984 (#9012)

**Related Issue:** #8984

## Summary

This PR integrates recently merged changes to Tile in `main` into the
tokens branch in order to (hopefully) eliminate merge conflicts when the
tokens branch goes into `main`.

Co-authored-by: Erik Harper <[email protected]>
@kevindoshier
Copy link
Contributor

@jcfranco - we were using content-end to achieve this, with the action added to the end of the tile, is there a better way to do this now?

image

@geospatialem
Copy link
Member

@jcfranco - we were using content-end to achieve this, with the action added to the end of the tile, is there a better way to do this now?

@kevindoshier Would an action work in your use case? Perhaps something similar to this example: https://codepen.io/geospatialem/pen/JjVZgNL

image

@kevindoshier
Copy link
Contributor

@geospatialem - kind of, what would be the best way to add the outline on the nested block?

image

@geospatialem
Copy link
Member

@geospatialem - kind of, what would be the best way to add the outline on the nested block?

@kevindoshier Updated the Codepen to include a nested block - would this work? https://codepen.io/geospatialem/pen/JjVZgNL

image

@macandcheese
Copy link
Contributor

We should probably enhance Action to support href, rel, target, shouldn't have to use event listener for this kind of interaction.

@geospatialem
Copy link
Member

We should probably enhance Action to support href, rel, target, shouldn't have to use event listener for this kind of interaction.

Opened #9138

@kevindoshier
Copy link
Contributor

@geospatialem - thanks! That works!

@calcite-admin calcite-admin mentioned this pull request May 14, 2024
Merged
@calcite-admin calcite-admin mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macandcheese macandcheese macandcheese left review comments

@jcfranco jcfranco jcfranco approved these changes

Assignees

@eriklharper eriklharper

Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-03-26 - Mar Release
Development

Successfully merging this pull request may close these issues.
5 participants
@eriklharper @kevindoshier @geospatialem @macandcheese @jcfranco