-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use component tokens within includes #8771
Conversation
If we're going to keep using these we should convert them to |
Agreed. This could be done in any one of the following components for #7180 or in a follow up issue.
Combobox is the only component that uses xButton so it really shouldn't be in the includes. Ill move it to its own file. |
@jcfranco @macandcheese whats the history of Functional components should have their own CSS file as well. |
I think it was built to eventually support all close affordances - accepting arguments for round, square, stretch to fill, etc. as needed, but seems like it hasn't been adopted much. |
Input could also be a mixin, given there are so many very similar components |
# Conflicts: # packages/calcite-components/src/components/progress/progress.scss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕹️👾
margin: 0px; | ||
align-self: center; | ||
color: var(#{$textColor}, var(--calcite-color-text-3)); | ||
transition: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explicitly list the props that will be transitioned by state? Looks like it's color
and background-color
.
$borderWidth: "--calcite-border-width-md" | ||
) { | ||
.x-button { | ||
appearance: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we agreed to only inline Tailwind utils related to component tokens. FWIW, we can automate this step later to make it easier for review.
Related Issue: #7180
Summary