fix(input-time-zone): allow searching offsets by Etc/x time zone #7978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
requested review from
benelan,
driskull,
geospatialem and
a team
as code owners
github-actions
bot
added
the
bug
jcfranco
added
p - high
alisonailea
reviewed
Oct 11, 2023
| const page = await newE2EPage(); | ||
| await page.emulateTimezone(testTimeZoneNamesAndOffsets[0].name); | ||
| await page.setContent( | ||
| await addTimeZoneNamePolyfill(html` <calcite-input-time-zone></calcite-input-time-zone>`) |
There was a problem hiding this comment.
nitpick: remove the extra space after html`
There was a problem hiding this comment.
Agreed. Need to do a sweep of these. I think my IDE may be adding those extra spaces. 😅
alisonailea
approved these changes
Oct 11, 2023
anveshmekala
deleted the
jcfranco/7957-allow-searching-offsets-by-etc/x-time-zone
branch
Merged
geospatialem
pushed a commit
that referenced
this pull request
Oct 12, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 1.9.2</summary> ## [1.9.2](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-10-12) ### Bug Fixes * **flow-item:** Update collapsed property when collapse button is clicked ([#7960](#7960)) ([f6fd55f](f6fd55f)) * **input-time-zone:** Allow searching offsets by Etc/x time zone ([#7978](#7978)) ([2c34b42](2c34b42)) * **input-time-zone:** Fix error caused by time zone group filtering ([#7971](#7971)) ([521673e](521673e)) * **table:** Improve scrollbar display ([#7967](#7967)) ([593a1bf](593a1bf)) </details> <details><summary>@esri/calcite-components-react: 1.9.2</summary> ## [1.9.2](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-10-12) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^1.9.2-next.3 to ^1.9.2 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7957
Summary
This extended search behavior allows users to find
Etc/GMT+12, which would not appear before as it did not have a IANA identifier tied to a city.Note: this bumps
timezone-groupsto v0.8.0 which ensures allEtc/xtime zones are included in all groups.