Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linting): enable one-var rule #7528

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Aug 15, 2023

Related Issue: N/A

Summary

Enables one-var to prevent consecutive variable declarations. This should make it easier to vertically scan (both the variable and type).

one-var to rule them all,
   one-var to find them,
one-var to bring them all
   and in the darkness bind them.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Aug 15, 2023
@jcfranco jcfranco changed the title chore: enable one-line rule chore: enable one-var rule Aug 16, 2023
@jcfranco jcfranco marked this pull request as ready for review August 16, 2023 16:30
@jcfranco jcfranco requested review from benelan, driskull, geospatialem and a team as code owners August 16, 2023 16:30
@jcfranco jcfranco changed the title chore: enable one-var rule chore(linting): enable one-var rule Aug 16, 2023
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco added skip visual snapshots Pull requests that do not need visual regression testing. low risk Issues with low risk for consideration in low risk milestones labels Aug 17, 2023
@jcfranco jcfranco merged commit df2b911 into main Aug 18, 2023
@jcfranco jcfranco deleted the jcfranco/enable-one-line-rule branch August 18, 2023 19:16
@github-actions github-actions bot added this to the 1.6.1 Maintenance Release milestone Aug 18, 2023
benelan added a commit that referenced this pull request Aug 21, 2023
* origin/main:
  build(deps): update dependency autoprefixer to v10.4.15 (#7543)
  build(deps): update dependency postcss to v8.4.28 (#7544)
  chore: release main (#7539)
  chore: release next
  fix: fix open/close event emitting in Safari (#7551)
  chore(linting): set up spelling linting (#7389)
  chore(linting): enable one-var rule (#7528)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. low risk Issues with low risk for consideration in low risk milestones skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants