chore: remove references to removed cleanup script #7339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
requested review from
benelan,
driskull and
geospatialem
as code owners
github-actions
bot
added
the
chore
jcfranco
added
the
skip visual snapshots
benelan
reviewed
Jul 19, 2023
| "docs": "concurrently --kill-others --raw \"npm run build-storybook\" \"ts-node --esm ./support/cleanOnProcessExit.ts --path ./__docs-temp__\"", | ||
| "docs:preview": "concurrently --raw \"npm:util:build-docs && start-storybook\" \"ts-node --esm ./support/cleanOnProcessExit.ts --path ./__docs-temp__\"", | ||
| "docs": "concurrently --kill-others --raw \"npm run build-storybook\"", | ||
| "docs:preview": "concurrently --raw \"npm:util:build-docs && start-storybook\"", |
There was a problem hiding this comment.
I don't think these need concurrently anymore now since they are both just a single argument now that we removed the cleanup script
There was a problem hiding this comment.
And can you append this to the scripts like in start:
npm run util:clean-js-files &&There was a problem hiding this comment.
Nice catch. ✨🎣✨ Fixing!
jcfranco
deleted the
jcfranco/remove-references-to-removed-cleanup-script
branch
benelan
added a commit
that referenced
this pull request
Jul 20, 2023
…shot-doc * origin/main: chore: release next fix(tooltip): ensure --calcite-app-z-index-tooltip is applied (#7345) docs: add warning notice to internal storybook (#7338) chore: remove references to removed cleanup script (#7339) chore: drop Airtable syncing action (#7340) chore: release next fix(color-picker): maintains correct numbering system when entering invalid RGB value (#7327) ci: notify teams about calcite-components releases only (#7317) build(deps): Bump rollup from 2.77.1 to 3.26.0 (#7264) build(deps): Bump eslint-plugin-jsdoc from 46.4.3 to 46.4.4 (#7329) build(deps): Bump semver and @types/semver (#7309)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
Update doc scripts to no longer reference
cleanOnProcessExit.ts(removed via #7294).