create types for using calcite components with preact + typescript #693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While setting up CC with a preact project that used TypeScript I ran into a lot of problems. First, you get the "Property 'insert-calcite-tag-name' does not exist on type 'JSX.IntrinsicElements':
So you have to augment the intrinsic elements types with the custom tag names from calcite components. After you do that, then you realize that the event names don't work in preact if you use the events from the provided types. Ie
onDropdownClose
will never fire, you have to useondropdownClose
:This is a temporary fix that uses a custom output target to generate an additional typescript file for preact. If we get the ds framework bindings up and running, we may be able to get rid of this, but for now it allows cc to be used in the TS + preact project by importing these types. note this ts file expects preact as a peer dependency.
/cc @nathan-barrett