fix(dropdown-item): bumping the scale of icon to M when parent dropdown is scale L #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
Elijbet
added
the
pr ready for visual snapshots
alisonailea
approved these changes
Jan 10, 2023
Elijbet
added
pr ready for visual snapshots
Elijbet
deleted the
elijbet/5698-dropdown-item-scale-L-renders-icon-scale-M
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5698
Summary
Bumping the scale of the icon to M when the parent
dropdown-itemisscale="l"for a visual distinction between larger and smaller components without affecting the height of thedropdown-itemwhen icon(s) are added or removed. Added a_testOnlysnapshot.