refactor(modal, panel, popover)!: remove focusId param from setFocus method.
#6147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
benelan
approved these changes
Dec 21, 2022
src/components/popover/popover.tsx
Outdated
| } | ||
|
|
||
| focusFirstTabbable(this); | ||
| forceUpdate(this); |
There was a problem hiding this comment.
this should be forceUpdate(this.el) right?
src/components/popover/popover.tsx
Outdated
| @@ -552,7 +540,7 @@ export class Popover | |||
| renderCloseButton(): VNode { | |||
| const { messages, closable } = this; | |||
| return closable ? ( | |||
| <div class={CSS.closeButtonContainer}> | |||
| <div class={CSS.closeButtonContainer} key="close-button-container"> | |||
There was a problem hiding this comment.
Can you use CSS.closeButtonContainer for the key attribute instead of hardcoding it
src/components/popover/popover.tsx
Outdated
| @@ -575,7 +563,7 @@ export class Popover | |||
| ) : null; | |||
|
|
|||
| return headingNode ? ( | |||
| <div class={CSS.header}> | |||
| <div class={CSS.header} key="header"> | |||
There was a problem hiding this comment.
Reuse the string from resources here as well por favor
benelan
added a commit
that referenced
this pull request
Dec 27, 2022
* master: chore(modal): Remove invalid kind values (#6169) build: update browserslist db (#6171) docs: update component READMEs (#6168) refactor(combobox-item)!: remove `toggleSelected` method. (#6162) chore(color-picker): add missing message in `en` bundle (#6165) refactor(popover)!: remove `toggle` method. (#6161) docs: update component READMEs (#6163) refactor(modal, panel, popover)!: remove `focusId` param from `setFocus` method. (#6147) feat(tab-nav): Add `selectedTitle` property (#6149)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Removed
focusIdparameter fromsetFocusmethods. When thesetFocusmethod is called the first focusable element will be focused.