Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(input-time-picker): Add reposition method #4448

Merged
merged 1 commit into from
Apr 26, 2022
Merged

feat(input-time-picker): Add reposition method #4448

merged 1 commit into from
Apr 26, 2022

Conversation

driskull
Copy link
Member

Related Issue: #4364

Summary

feat(input-time-picker): Add reposition method. (#4364)

@github-actions github-actions bot added this to the Sprint 04/25 - 05/6 milestone Apr 25, 2022
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Apr 25, 2022
@driskull driskull marked this pull request as ready for review April 25, 2022 22:21
@driskull driskull requested a review from a team as a code owner April 25, 2022 22:21
jcfranco
jcfranco approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco
Copy link
Member

I noticed that none of the popper owners have tests for reposition. Can you open a test issue to set one up? Maybe we can enhance the popperOwner helper to handle this.

@driskull
Copy link
Member Author

I noticed that none of the popper owners have tests for reposition. Can you open a test issue to set one up? Maybe we can enhance the popperOwner helper to handle this.

Maybe we can just setup a "PopperOwner" class for them to inherit to make sure they have one?

@driskull driskull mentioned this pull request Apr 26, 2022
Open
@driskull driskull merged commit 7097b3b into master Apr 26, 2022
@driskull driskull deleted the dris0000/input-time-picker-reposition branch April 26, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@driskull driskull

Labels
enhancement Issues tied to a new feature or request.
Projects
None yet
Milestone
Sprint 04/25 - 05/6
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @jcfranco