Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use getElementStyleDir where applicable. #2079 #3622

Merged
merged 1 commit into from
Dec 6, 2021
Merged

refactor: Use getElementStyleDir where applicable. #2079 #3622

merged 1 commit into from
Dec 6, 2021

Conversation

driskull
Copy link
Member

@driskull driskull commented Dec 3, 2021

Related Issue: #2079

Summary

refactor: Use getElementStyleDir where applicable. #2079

  • User getElementStyleDir where necessary.
  • This utility is used when direction is needed to perform a JS action such as keyboard events, icon swapping, etc.
  • This utility shouldn't be used to set a class or styling. CSS logical properties should be used instead.

@driskull driskull requested a review from jcfranco December 3, 2021 18:18
@driskull driskull self-assigned this Dec 3, 2021
@driskull driskull requested a review from a team as a code owner December 3, 2021 18:18
@github-actions github-actions bot added this to the Sprint 12/6 - 12/17 milestone Dec 3, 2021
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Dec 3, 2021
@driskull driskull merged commit d7f78a9 into master Dec 6, 2021
@driskull driskull deleted the dris0000/refactor-getElementDir branch December 6, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriklharper eriklharper eriklharper approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco

Assignees

@driskull driskull

Labels
refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
Sprint 12/6 - 12/17
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @eriklharper