Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(slider, loader): prevent Sass deprecation warnings from being thrown on start #3320

Merged
merged 8 commits into from
Nov 2, 2021
Merged

refactor(slider, loader): prevent Sass deprecation warnings from being thrown on start #3320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e03d229
refactor(slider, loader): remove sass deprecation warnings
caripizza Oct 20, 2021
b10c7cb
Merge branch 'master' into caripizza/fix-sass-deprecation-warnings
caripizza Oct 21, 2021
67e6c3a
Merge branch 'master' into caripizza/fix-sass-deprecation-warnings
caripizza Oct 25, 2021
022755d
Merge branch 'master' into caripizza/fix-sass-deprecation-warnings
caripizza Oct 25, 2021
e361ae5
Merge branch 'master' into caripizza/fix-sass-deprecation-warnings
caripizza Oct 26, 2021
7e6e014
Merge branch 'master' into caripizza/fix-sass-deprecation-warnings
caripizza Oct 28, 2021
89336cf
Merge branch 'master' into caripizza/fix-sass-deprecation-warnings
caripizza Oct 29, 2021
5d47b52
Merge branch 'master' into caripizza/fix-sass-deprecation-warnings
caripizza Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/calcite-loader/calcite-loader.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ $loader-circumference: ($loader-scale - (2 * $stroke-width)) * 3.14159;
- duration how long the segment takes to rotate 360° (seconds)
*/
@mixin generateSegment($i, $size, $growth, $duration) {
$circumference: $loader-circumference / $loader-scale * 100%;
$circumference: calc($loader-circumference / $loader-scale) * 100%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

$length: ($size * 0.01) * $circumference;
$end: $length + ($growth * 0.01) * $circumference;
.loader__svg--#{$i} {
Expand Down
4 changes: 2 additions & 2 deletions src/components/calcite-slider/calcite-slider.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ $tick-height: 4px;
transform: translate(7px, -8px);

.handle__label {
@include font-size(-4);
font-size: var(--calcite-font-size--2);
font-weight: 500;
line-height: 1;
color: var(--calcite-ui-text-2);
Expand Down Expand Up @@ -310,7 +310,7 @@ $tick-height: 4px;

.tick__label {
position: absolute;
@include font-size(-4);
font-size: var(--calcite-font-size--2);
font-weight: 500;
color: var(--calcite-ui-text-2);
width: 4em;
Expand Down