Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): style the current svg checkbox and interdeterminate icon to be bolder #2848 #3250

Merged
merged 26 commits into from
Oct 18, 2021

Conversation

y0n4
Copy link
Contributor

@y0n4 y0n4 commented Oct 14, 2021

Related Issue: #2848

Summary

Updated the check and indeterminate icon svg to be thicker by adding styling. Thank you @caripizza for the suggestion

Before
before
After
wstyle

y0n4 and others added 18 commits September 30, 2021 13:37
…ve to its scale size (#3144) (#3197)

* fix(combox-item): adjust height of the item to be consistent respective to its scale size (#3144)

* fix(combobox-item): keep the container styling relative to the scale size

* fix(combobox-item): review pr comment suggestion for styling
Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/lib/cli) from 6.3.10 to 6.3.11.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.11/lib/cli)

---
updated-dependencies:
- dependency-name: storybook
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@storybook/html](https://github.com/storybookjs/storybook/tree/HEAD/app/html) from 6.3.10 to 6.3.11.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.11/app/html)

---
updated-dependencies:
- dependency-name: "@storybook/html"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nt (#3231)

* fix(dropdown): close on outside click when disable-close-on-select is true #3136

* fix(dropdown): remove preventDefault on click event. #1709
#3143)

* fix(combobox): add chevron icon at end of input regardless of selection mode (#3055)

* fix(combobox): align the chevron icon to be centered vertically on multiple chips select mode (#3055)

* fix(action-bar): get up-to-date master changes

* feat(combobox): add additional story for multiple with preselected inputs

* fix(combobox): make all the combobox height size consistent scale
@y0n4 y0n4 requested a review from a team as a code owner October 14, 2021 21:43
@github-actions github-actions bot added this to the Sprint 10/11 – 10/22 milestone Oct 14, 2021
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Oct 14, 2021
Copy link
Contributor

@caripizza caripizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @y0n4! I left a comment about using TW utility classes for this change just so you know that's an option too. Can you remove that erroneous .test class as well on this pr?

@caripizza
Copy link
Contributor

@y0n4 can you rename the pr title since we didn't end up reverting that svg code in this one?

@y0n4 y0n4 changed the title fix(checkbox): simply add thicker stroke to the checkbox svg and retract the svg upgrade provided #2848 fix(checkbox): style the current svg checkbox and interdeterminate icon to be bolder #2848 Oct 15, 2021
Copy link
Contributor

@caripizza caripizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@y0n4 y0n4 force-pushed the y0n4/2848-checkbox-upgrade-svg branch from 3062dff to f35ecac Compare October 18, 2021 23:06
@y0n4 y0n4 merged commit 4503631 into master Oct 18, 2021
@y0n4 y0n4 deleted the y0n4/2848-checkbox-upgrade-svg branch October 18, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants