-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(checkbox): style the current svg checkbox and interdeterminate icon to be bolder #2848 #3250
Conversation
…/3055-display-chevron
Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/lib/cli) from 6.3.10 to 6.3.11. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.3.11/lib/cli) --- updated-dependencies: - dependency-name: storybook dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@storybook/html](https://github.com/storybookjs/storybook/tree/HEAD/app/html) from 6.3.10 to 6.3.11. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.3.11/app/html) --- updated-dependencies: - dependency-name: "@storybook/html" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…act the svg upgrade provided #2848
#3143) * fix(combobox): add chevron icon at end of input regardless of selection mode (#3055) * fix(combobox): align the chevron icon to be centered vertically on multiple chips select mode (#3055) * fix(action-bar): get up-to-date master changes * feat(combobox): add additional story for multiple with preselected inputs * fix(combobox): make all the combobox height size consistent scale
…/2848-checkbox-upgrade-svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @y0n4! I left a comment about using TW utility classes for this change just so you know that's an option too. Can you remove that erroneous .test
class as well on this pr?
@y0n4 can you rename the pr title since we didn't end up reverting that svg code in this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…/2848-checkbox-upgrade-svg
3062dff
to
f35ecac
Compare
Related Issue: #2848
Summary
Updated the check and indeterminate icon svg to be thicker by adding styling. Thank you @caripizza for the suggestion
Before


After