Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): do not open after the pointer has moved off of the reference element #11599

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

driskull
Copy link
Member

@driskull driskull commented Feb 20, 2025

Related Issue: #11091

Summary

  • No longer opens the tooltip after the pointer has moved off of the reference element
    • Clears open timeout when pointer moved and the same tooltip's reference element is no longer hovered
    • If opening and the hover tooltip doesn't match the tooltip being opened, nothing happens.
  • Modify delay opening tooltips when a tooltip is already open from 0ms to 100ms which is a third the usual time.
  • Modify delay closing tooltips from 500ms to 450ms which is a factor of 1.5 times the opening delay.

@driskull
Copy link
Member Author

@macandcheese @DitwanP would you mind testing this out?

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 20, 2025
@driskull driskull changed the title fix(tooltip): do open after the mouse has already left the reference element fix(tooltip): no longer open after the mouse has left the reference element Feb 20, 2025
@driskull driskull changed the title fix(tooltip): no longer open after the mouse has left the reference element fix(tooltip): do not open after the pointer has moved off of the reference element Feb 20, 2025
@DitwanP
Copy link
Contributor

DitwanP commented Feb 20, 2025

Screen.Recording.2025-02-20.at.9.00.29.AM.mov

I will say that in the screen recording you can see that there's still moments where as your scrolling over multiple tooltips they seem to be opening pretty fast even when you don't stay hovered on them. Still, that behavior is now much better than what's currently live.

If the TOOLTIP_QUICK_OPEN_DELAY_MS is what has made that improvement, maybe bumping it a touch more could make it not show up as often.

Other than that, Looks like the main issue is fixed to me! 👍

@driskull
Copy link
Member Author

If the TOOLTIP_QUICK_OPEN_DELAY_MS is what has made that improvement, maybe bumping it a touch more could make it not show up as often.

Currently, the tooltips open first at 300ms but then after a tooltip is already open the next tooltip opens faster. Previously it was set to open at 0ms from #6396 but here I increased it slightly to 25ms

I can try bumping it to 150ms and see if that helps.

@DitwanP
Copy link
Contributor

DitwanP commented Feb 20, 2025

I can try bumping it to 150ms and see if that helps.

Definitely feels a bit better to me. 👍

Copy link
Contributor

@DitwanP DitwanP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants