Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rating, segmented-control): improve event handler types #11595

Merged
merged 1 commit into from
Feb 21, 2025
Merged

chore(rating, segmented-control): improve event handler types #11595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/calcite-components/src/components/rating/rating.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ export class Rating
target.focus();
}

private handleLabelClick(event: Event) {
private handleLabelClick(event: MouseEvent) {
//preventing pointerdown event will suppress any compatibility mouse events except for click event.
event.preventDefault();
}
Expand Down
2 changes: 1 addition & 1 deletion packages/calcite-components/src/components/segmented-control/segmented-control.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ export class SegmentedControl
}
}

private handleSelected(event: Event): void {
private handleSelected(event: CustomEvent<void>): void {
event.preventDefault();
const el = event.target as SegmentedControlItem["el"];
if (el.checked) {
Expand Down
Loading