feat(chip): deprecate pressed in favor of press
#11389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonailea
requested review from
jcfranco,
eriklharper,
driskull,
macandcheese and
Elijbet
github-actions
bot
added
the
chore
driskull
reviewed
Jan 27, 2025
| @@ -10,7 +10,8 @@ | |||
| * @prop --calcite-chip-icon-color: Specifies the component's icon color. | |||
| * @prop --calcite-chip-close-icon-color: Specifies the component's close element icon color. | |||
| * @prop --calcite-chip-select-icon-color: Specifies the component's selection element icon color. | |||
| * @prop --calcite-chip-select-icon-color-pressed: Specifies the component's selection element icon color when active. | |||
| * @prop --calcite-chip-select-icon-color-pressed: [deprecate] Use `--calcite-chip-select-icon-color-press`. Specifies the component's selection element icon color when active. | |||
| * @prop --calcite-chip-select-icon-color-press: Specifies the component's selection element icon color when active. | |||
There was a problem hiding this comment.
@alisonailea it doesn't look like this new var is used anywhere? Should there also be tests here?
driskull
requested changes
Jan 27, 2025
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
alisonailea
changed the title
pressed in favor of press
github-actions
bot
added
the
enhancement
alisonailea
removed
the
Stale
driskull
approved these changes
Feb 12, 2025
alisonailea
added
the
pr ready for visual snapshots
|
@alisonailea Can you amend the PR title as suggested above? From the changelog perspective, "pressed"/"press" isn't clear on its own, so tokens context is needed. Here are the steps to amend the conventional commit entry (see example). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10832
Summary
Deprecate
--calcite-chip-select-icon-color-pressedtoken.Add
--calcite-chip-select-icon-color-press: Specifies the component's selection element icon color when active.