fix: floating ui elements set max-content for inline-size #11095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
driskull
added
no changelog entry
driskull
added
pr ready for visual snapshots
driskull
added
pr ready for visual snapshots
jcfranco
approved these changes
Dec 18, 2024
| > | ||
| ${contentHTML} | ||
| </calcite-popover> | ||
| <div style="width: 800px; height:800px;"> |
There was a problem hiding this comment.
Yes that would be very helpful. We already do variations of this for some components.
There was a problem hiding this comment.
Sweet. I'll create an issue for this.
driskull
deleted the
dris0000/floating-ui-set-max-content-inline-size
branch
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
eriklharper
added a commit
that referenced
this pull request
Dec 20, 2024
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
**Related Issue:** #10731 ## Summary - Follows [`floating-ui`'s initial layout recommendation](https://floating-ui.com/docs/computeposition#initial-layout). - Combobox wasn't correctly handling the size when in fixed overlay positioning - Example: https://codepen.io/Matt-Driscoll/pen/raByNmQ?editors=1010 - updated tooltip and popover stories where stories were being cut off due to sizing. BEGIN_COMMIT_OVERRIDE END_COMMIT_OVERRIDE
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10731
Summary
floating-ui's initial layout recommendation.BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE